[GH-ISSUE #3203] Pass a `&Message` to `verify_nsec()` and `verify_nsec3()` #1152

New issue

Open

opened 2026-03-16 01:44:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:44:38 +03:00

Owner

Originally created by @divergentdave on GitHub (Aug 13, 2025).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/3203

Currently we pass multiple parts of a message to verify_nsec() and verify_nsec3(), like the response code, NSEC or NSEC3 records, the answer section, and the SOA record. We could move a lot of this inside each function by just passing a reference to the whole message. This would clean up verify_response(). In particular, we don't need to collect vectors of references to name-RDATA tuples for NSEC and NSEC3 records.

Proposed in https://github.com/hickory-dns/hickory-dns/pull/3175#discussion_r2273507689

Originally created by @divergentdave on GitHub (Aug 13, 2025). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/3203 Currently we pass multiple parts of a message to `verify_nsec()` and `verify_nsec3()`, like the response code, NSEC or NSEC3 records, the answer section, and the SOA record. We could move a lot of this inside each function by just passing a reference to the whole message. This would clean up `verify_response()`. In particular, we don't need to collect vectors of references to name-RDATA tuples for NSEC and NSEC3 records. Proposed in https://github.com/hickory-dns/hickory-dns/pull/3175#discussion_r2273507689