[PR #2647] [MERGED] Conformance: test Hickory DNS with ring as well #3203

New issue

Closed

opened 2026-03-16 11:30:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:30:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2647
Author: @divergentdave
Created: 12/5/2024
Status: ✅ Merged
Merged: 12/6/2024
Merged by: @djc

Base: main ← Head: david/conformance-cargo-features

📝 Commits (5)

1ccef91 Conformance: Configurable Hickory DNS features
1e75577 Show nameserver logs on failure of NSEC3 tests
726c39c Switch between PEM and PKCS8 keys for nameserver
25f26fe Update justfile to invoke conformance-hickory-ring
0e94b52 Change default of DNSSEC_FEATURE to dnssec-ring

📊 Changes

8 files changed (+148 additions, -35 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/name_server/rfc5155.rs (+6 -2)
📝 conformance/packages/dns-test/src/container.rs (+39 -13)
📝 conformance/packages/dns-test/src/docker/hickory.Dockerfile (+3 -1)
📝 conformance/packages/dns-test/src/implementation.rs (+51 -11)
📝 conformance/packages/dns-test/src/lib.rs (+12 -5)
📝 conformance/packages/dns-test/src/name_server.rs (+24 -1)
📝 conformance/packages/dns-test/src/templates/hickory.name-server.toml.jinja (+4 -0)
📝 justfile (+9 -2)

📄 Description

This PR adds another optional parameter to the DNS_TEST_SUBJECT environment variable, to allow choosing between the dnssec-openssl and dnssec-ring Cargo features. I also added support for providing either a PEM or PKCS8 private key to a Hickory name server, depending on which library it is using. This flexibility will also be useful in the near future when we add aws-lc-rs.

This is a rebased version of #2593.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2647 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 12/5/2024 **Status:** ✅ Merged **Merged:** 12/6/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/conformance-cargo-features` --- ### 📝 Commits (5) - [`1ccef91`](https://github.com/hickory-dns/hickory-dns/commit/1ccef914b476536dce564b4dee1b2c1caecba176) Conformance: Configurable Hickory DNS features - [`1e75577`](https://github.com/hickory-dns/hickory-dns/commit/1e75577f4334e9894513f3d25b33c6778047aa0f) Show nameserver logs on failure of NSEC3 tests - [`726c39c`](https://github.com/hickory-dns/hickory-dns/commit/726c39c543c437675fcfe17aed885211b2022d9e) Switch between PEM and PKCS8 keys for nameserver - [`25f26fe`](https://github.com/hickory-dns/hickory-dns/commit/25f26fe5baea9483d70759d166c6e57a45e45a56) Update justfile to invoke conformance-hickory-ring - [`0e94b52`](https://github.com/hickory-dns/hickory-dns/commit/0e94b52d5ff6f20649f3cb26d6472b36b5ecfa85) Change default of DNSSEC_FEATURE to dnssec-ring ### 📊 Changes **8 files changed** (+148 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/name_server/rfc5155.rs` (+6 -2) 📝 `conformance/packages/dns-test/src/container.rs` (+39 -13) 📝 `conformance/packages/dns-test/src/docker/hickory.Dockerfile` (+3 -1) 📝 `conformance/packages/dns-test/src/implementation.rs` (+51 -11) 📝 `conformance/packages/dns-test/src/lib.rs` (+12 -5) 📝 `conformance/packages/dns-test/src/name_server.rs` (+24 -1) 📝 `conformance/packages/dns-test/src/templates/hickory.name-server.toml.jinja` (+4 -0) 📝 `justfile` (+9 -2) </details> ### 📄 Description This PR adds another optional parameter to the `DNS_TEST_SUBJECT` environment variable, to allow choosing between the `dnssec-openssl` and `dnssec-ring` Cargo features. I also added support for providing either a PEM or PKCS8 private key to a Hickory name server, depending on which library it is using. This flexibility will also be useful in the near future when we add aws-lc-rs. This is a rebased version of #2593. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>