[GH-ISSUE #3084] What should Hickory DNS's default be for trust_negative_responses? #1129

New issue

Closed

opened 2026-03-16 01:41:13 +03:00 by kerem · 1 comment

kerem commented

2026-03-16 01:41:13 +03:00

Owner

Originally created by @iximeow on GitHub (Jun 23, 2025).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/3084

in 2022 NameServerConfig got a NameServerConfig::new() to create a config with some defaults, with trust_nx_responses: true. at the same time, the doc comment for trust_negative_responses refers to an older default of false from when it was serializable with serde. and then more recently, #3052 set the defaults in the builders back to trust_negative_responses: false.

it seems like trust_negative_responses: true generally seems like a reasonable default, but whatever it is the doc comment should be aligned with the builders!

Originally created by @iximeow on GitHub (Jun 23, 2025). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/3084 in 2022 `NameServerConfig` got a `NameServerConfig::new()` to create a config with some defaults, with [`trust_nx_responses: true`](https://github.com/hickory-dns/hickory-dns/commit/25861da44e6214a199940469613db76c9123830e#diff-843ae31058bed4455ea8974e6c028e6b97404c7a79620e04b69f4174ebfb6ad4R428). at the same time, the doc comment for [trust_negative_responses](https://github.com/hickory-dns/hickory-dns/blob/7dc7ffe/crates/resolver/src/config.rs#L189) refers to an older default of `false` from when it was serializable with `serde`. and then more recently, #3052 set the defaults in the builders back to `trust_negative_responses: false`. it seems like `trust_negative_responses: true` generally seems like a reasonable default, but whatever it is the doc comment should be aligned with the builders!