[GH-ISSUE #3068] Ensure that raw and decoded messages in Request match #1126

New issue

Closed

opened 2026-03-16 01:41:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:41:02 +03:00

Owner

Originally created by @divergentdave on GitHub (Jun 18, 2025).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/3068

We should split Request::new() into two separate constructors, one that encapsulates decoding a MessageRequest from an incoming message, and one that takes a MessageRequest and encodes it (for use in tests).

Originally posted by @divergentdave in https://github.com/hickory-dns/hickory-dns/pull/3060#discussion_r2155342585

Originally created by @divergentdave on GitHub (Jun 18, 2025). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/3068 We should split `Request::new()` into two separate constructors, one that encapsulates decoding a `MessageRequest` from an incoming message, and one that takes a `MessageRequest` and encodes it (for use in tests). _Originally posted by @divergentdave in https://github.com/hickory-dns/hickory-dns/pull/3060#discussion_r2155342585_