[PR #2471] [MERGED] server: avoid wrapping Arc in Box #3068

New issue

Closed

opened 2026-03-16 11:23:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:23:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2471
Author: @djc
Created: 9/21/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @marcus0x62

Base: main ← Head: arc-authorities

📝 Commits (1)

06c3976 server: avoid wrapping Arc in Box

📊 Changes

10 files changed (+74 additions, -84 deletions)

View changed files

📝 bin/src/hickory-dns.rs (+8 -8)
📝 crates/server/src/authority/authority_object.rs (+20 -27)
📝 crates/server/src/authority/catalog.rs (+14 -17)
📝 tests/integration-tests/tests/integration/catalog_tests.rs (+18 -18)
📝 tests/integration-tests/tests/integration/client_future_tests.rs (+3 -3)
📝 tests/integration-tests/tests/integration/client_tests.rs (+2 -2)
📝 tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs (+1 -1)
📝 tests/integration-tests/tests/integration/lookup_tests.rs (+4 -4)
📝 tests/integration-tests/tests/integration/server_future_tests.rs (+2 -2)
📝 tests/integration-tests/tests/integration/truncation_tests.rs (+2 -2)

📄 Description

Noticed this pre-existing issue while reviewing #2161. There doesn't seem to be a need to wrap Arc in Box, since the former already includes a heap allocation and can support trait objects directly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2471 **Author:** [@djc](https://github.com/djc) **Created:** 9/21/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `arc-authorities` --- ### 📝 Commits (1) - [`06c3976`](https://github.com/hickory-dns/hickory-dns/commit/06c3976e4607bc47d248b180cc75c395c2d76472) server: avoid wrapping Arc in Box ### 📊 Changes **10 files changed** (+74 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/hickory-dns.rs` (+8 -8) 📝 `crates/server/src/authority/authority_object.rs` (+20 -27) 📝 `crates/server/src/authority/catalog.rs` (+14 -17) 📝 `tests/integration-tests/tests/integration/catalog_tests.rs` (+18 -18) 📝 `tests/integration-tests/tests/integration/client_future_tests.rs` (+3 -3) 📝 `tests/integration-tests/tests/integration/client_tests.rs` (+2 -2) 📝 `tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs` (+1 -1) 📝 `tests/integration-tests/tests/integration/lookup_tests.rs` (+4 -4) 📝 `tests/integration-tests/tests/integration/server_future_tests.rs` (+2 -2) 📝 `tests/integration-tests/tests/integration/truncation_tests.rs` (+2 -2) </details> ### 📄 Description Noticed this pre-existing issue while reviewing #2161. There doesn't seem to be a need to wrap `Arc` in `Box`, since the former already includes a heap allocation and can support trait objects directly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>