mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #3049] Preserving RDATA of invalid SVCB records #1119
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#1119
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @divergentdave on GitHub (Jun 12, 2025).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/3049
The first issue I found with the
preserve_rdatafuzzer after #3047 is with SVCB records. When a parameter of known type has a SvcParamValue that is longer than necessary, for example aportwith a value longer than two bytes, the extra data is discarded when parsing the record. First of all, we should have some sort of check for extra data in the nested decoder after successfully parsing a value. Secondly, we should store the wholeSvcParamsfield of the RDATA as-is, so it can be transparently re-encoded, and only try to interpret it as parameters on demand.