[PR #2449] [MERGED] Fix dns-over-openssl compilation and CI coverage #3049

New issue

Closed

opened 2026-03-16 11:22:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:22:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2449
Author: @divergentdave
Created: 9/10/2024
Status: ✅ Merged
Merged: 9/10/2024
Merged by: @djc

Base: main ← Head: david/fix-dns-over-openssl

📝 Commits (2)

68f500e Fix compilation with dns-over-openssl
f706947 Fix dns-over-openssl target in justfile

📊 Changes

6 files changed (+43 additions, -13 deletions)

View changed files

📝 bin/tests/named_openssl_tests.rs (+3 -1)
📝 crates/server/src/config/dnssec.rs (+8 -4)
📝 justfile (+2 -2)
📝 tests/integration-tests/src/example_authority.rs (+10 -2)
📝 tests/integration-tests/tests/catalog_tests.rs (+10 -2)
📝 tests/integration-tests/tests/truncation_tests.rs (+10 -2)

📄 Description

I noticed that just dns-over-openssl was testing the wrong Cargo feature, thus dns-over-openssl hasn't had CI coverage for some time. I fixed that, along with various related bitrot problems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2449 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/10/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/fix-dns-over-openssl` --- ### 📝 Commits (2) - [`68f500e`](https://github.com/hickory-dns/hickory-dns/commit/68f500eebcf443c12ebcc755978caf4a97bec24e) Fix compilation with dns-over-openssl - [`f706947`](https://github.com/hickory-dns/hickory-dns/commit/f7069479130b6a560324f60300a92b4221359d15) Fix dns-over-openssl target in justfile ### 📊 Changes **6 files changed** (+43 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/named_openssl_tests.rs` (+3 -1) 📝 `crates/server/src/config/dnssec.rs` (+8 -4) 📝 `justfile` (+2 -2) 📝 `tests/integration-tests/src/example_authority.rs` (+10 -2) 📝 `tests/integration-tests/tests/catalog_tests.rs` (+10 -2) 📝 `tests/integration-tests/tests/truncation_tests.rs` (+10 -2) </details> ### 📄 Description I noticed that `just dns-over-openssl` was testing the wrong Cargo feature, thus `dns-over-openssl` hasn't had CI coverage for some time. I fixed that, along with various related bitrot problems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>