starred/hickory-dns

Fork 0

mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 03:05:51 +03:00

[GH-ISSUE #2511] feat(serde-config)[proto]: `Message` is not deriving `Serialize`/`Deserialize` #1008

New issue

Open

opened 2026-03-16 01:15:21 +03:00 by kerem · 5 comments

kerem commented

2026-03-16 01:15:21 +03:00

Owner

Originally created by @ArjixWasTaken on GitHub (Oct 16, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2511

About

One would expect having the feature serde-config enabled, would make all important structs be serializable/deserializable.
Sadly that is not the reality, the following types do not derive the needed macros.

Message
Header
Edns
Query
MessageType
OpCode
ResponseCode

Reproduction

Attempt to serialize a Message using serde.

Expected behavior

For serde to be able to serialize Message.

Version:

Crate: proto
Version: 0.24.1

Originally created by @ArjixWasTaken on GitHub (Oct 16, 2024). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2511 ## About One would expect having the feature `serde-config` enabled, would make all important structs be serializable/deserializable. Sadly that is not the reality, the following types do not derive the needed macros. - `Message` - `Header` - `Edns` - `Query` - `MessageType` - `OpCode` - `ResponseCode` ## Reproduction Attempt to serialize a `Message` using serde. ## Expected behavior For serde to be able to serialize `Message`. ## Version: Crate: proto Version: 0.24.1

kerem added the

tools

label

2026-03-16 01:15:21 +03:00

kerem commented

2026-03-16 01:15:33 +03:00

Author

Owner

@ArjixWasTaken commented on GitHub (Oct 16, 2024):

For now I can sort-off go around this issue by having a 1:1 clone of those structs, and implement conversion functions.
It ain't pretty

@ArjixWasTaken commented on GitHub (Oct 16, 2024): For now I can sort-off go around this issue by having a 1:1 clone of those structs, and implement conversion functions. It ain't pretty ![image](https://github.com/user-attachments/assets/074a81d4-4f66-4415-b047-74e90aafd6f6) -- ![image](https://github.com/user-attachments/assets/1279e8d5-3c4a-474f-a547-b85e27614fab)

kerem commented

2026-03-16 01:15:38 +03:00

Author

Owner

@djc commented on GitHub (Oct 16, 2024):

Well, these types really don't fit the mold of -config specifically. Perhaps we should generalize to a serde flag more broadly, but your use case seems pretty niche.

@djc commented on GitHub (Oct 16, 2024): Well, these types really don't fit the mold of `-config` specifically. Perhaps we should generalize to a `serde` flag more broadly, but your use case seems pretty niche.

kerem commented

2026-03-16 01:15:43 +03:00

Author

Owner

@ArjixWasTaken commented on GitHub (Oct 16, 2024):

Could you entertain me as to what the postfix -config means in the project?

@ArjixWasTaken commented on GitHub (Oct 16, 2024): Could you entertain me as to what the postfix `-config` means in the project?

kerem commented

2026-03-16 01:15:48 +03:00

Author

Owner

@djc commented on GitHub (Oct 16, 2024):

AIUI serde-config is mainly used to enable TOML configuration in the main hickory-dns binary crate.

@djc commented on GitHub (Oct 16, 2024): AIUI `serde-config` is mainly used to enable TOML configuration in the main hickory-dns binary crate.

kerem commented

2026-03-16 01:15:53 +03:00

Author

Owner

@ArjixWasTaken commented on GitHub (Oct 16, 2024):

I see, that makes a lot of sense.
A general serde feature would be nice to have.

@ArjixWasTaken commented on GitHub (Oct 16, 2024): I see, that makes a lot of sense. A general `serde` feature would be nice to have.

kerem referenced this issue

2026-03-16 02:36:56 +03:00

[PR #1008] [MERGED] clean up clippy warnings for Rust 1.41 #1861

kerem referenced this issue

2026-03-16 02:51:45 +03:00

[PR #1008] [MERGED] clean up clippy warnings for Rust 1.41 #1866