[PR #1679] [MERGED] Remove forced Mutex from handler #2511

New issue

Closed

opened 2026-03-16 09:50:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 09:50:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1679
Author: @jeff-hiner
Created: 4/7/2022
Status: ✅ Merged
Merged: 4/8/2022
Merged by: @bluejekyll

Base: main ← Head: remove_server_mutex

📝 Commits (2)

3ca5fc7 Remove forced Mutex from handler
50e85b2 Fixups

📊 Changes

3 files changed (+10 additions, -14 deletions)

View changed files

📝 crates/server/src/server/https_handler.rs (+2 -2)
📝 crates/server/src/server/quic_handler.rs (+2 -2)
📝 crates/server/src/server/server_future.rs (+6 -10)

📄 Description

The mutex here causes severe performance issues if you write e.g. a DNS proxy where some delegates take longer than others-- it forces serialization between invocations of request_handler but it's not required because there are no mutable borrows of self.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1679 **Author:** [@jeff-hiner](https://github.com/jeff-hiner) **Created:** 4/7/2022 **Status:** ✅ Merged **Merged:** 4/8/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `remove_server_mutex` --- ### 📝 Commits (2) - [`3ca5fc7`](https://github.com/hickory-dns/hickory-dns/commit/3ca5fc7558760f57b9c3c74ead9e2507e71ed1f3) Remove forced Mutex from handler - [`50e85b2`](https://github.com/hickory-dns/hickory-dns/commit/50e85b27e9dfb56ae96e0f8e635212e3dc0c4d9f) Fixups ### 📊 Changes **3 files changed** (+10 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/server/https_handler.rs` (+2 -2) 📝 `crates/server/src/server/quic_handler.rs` (+2 -2) 📝 `crates/server/src/server/server_future.rs` (+6 -10) </details> ### 📄 Description The mutex here causes severe performance issues if you write e.g. a DNS proxy where some delegates take longer than others-- it forces serialization between invocations of `request_handler` but it's not required because there are no mutable borrows of self. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>