mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[PR #372] [CLOSED] Migrating unique_key to be a database property #940
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#940
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/healthchecks/healthchecks/pull/372
Author: @jameskirsop
Created: 5/28/2020
Status: ❌ Closed
Base:
master← Head:unique_key-becomes-database-saved-property📝 Commits (1)
f1acd7aImplementing changes, documentation and tests📊 Changes
7 files changed (+68 additions, -8 deletions)
View changed files
📝
CHANGELOG.md(+2 -0)➕
hc/api/migrations/0071_check_unique_key.py(+23 -0)📝
hc/api/models.py(+7 -4)📝
hc/api/tests/test_get_check.py(+17 -0)📝
hc/api/urls.py(+11 -0)📝
hc/api/views.py(+4 -1)📝
templates/docs/api.md(+4 -3)📄 Description
This PR addresses an issue raised in #370 so that either a UUID or unique_key can be used to efficiently filter for Checks using the unique_key returned to a Read Only API call to
/api/v1/checks.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.