mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #505] prunepings does not delete logs from web UI #370
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#370
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yonas on GitHub (May 3, 2021).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/505
After running the script, I still see log entries in the web UI when looking at a check's details page.
On first run, it reports having deleted a couple thousand pings. On second run, immediately after, it reports 0 pings pruned.
It seems like the web UI is either caching pings or using another source to fetch ping logs.
@cuu508 commented on GitHub (May 3, 2021):
prunepingsdeletes old pings, leaving the 100 most recent for every check.After running
prunepingsnothing should change in the web UI because the web UI is showing the last 100 pings for each check, andprunepingsdoes not touch these. It only deletes pings that the web UI would not show any more anyway.@yonas commented on GitHub (May 3, 2021):
Thanks, I've created a pull request to add that info to the final output so new users don't need to check the README. https://github.com/healthchecks/healthchecks/pull/506
@cuu508 commented on GitHub (May 5, 2021):
New users definitely should read README :-)
""Done! Pruned %d pings. Kept 100 most recent pings." has a couple problems:
I'm leaning towards leaving the management command as-is.