mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #1063] [Feature] Global dark mode - prior to logging in? #736
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#736
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rwjack on GitHub (Sep 18, 2024).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/1063
Every time my login times out, I am blasted with a white screen before I login.
This change could be a simple environment variable that enables dark mode globally (by default, meaning users can still use white mode if they chose so).
@cuu508 commented on GitHub (Sep 24, 2024):
Thanks for the suggestion.
How about instead extending the session cookie age, so the session doesn't time out?
There's a SESSION_COOKIE_AGE setting, with the default value set to to 2 weeks. On Healthchecks.io I've set it to one year. This means in practice I get never automatically logged out (unless I don't visit the site for more than a year ;-).
Healthchecks does not currently read SESSION_COOKIE_AGE from an environment variable (setting an environment variable with this name currently has no effect), but we could look into doing that.
@rwjack commented on GitHub (Sep 24, 2024):
Yeah, that would solve my particular issue. So to clarify, I would only get logged out, if I don't open HC for a year (with the variable set to a year obviously)?
I would honestly prefer to keep it at 2 weeks, but with that logic - so if I keep opening HC every 13 days, the cookie is refreshed and the session is extended - unless that is how it currently works?
I don't think I've ever went for 2 weeks without opening the page at least once, but I'm not 100% sure.
@cuu508 commented on GitHub (Oct 10, 2024):
I think I was mistaken about session expiry – Django sessions do not auto-refresh. If the session cookie expiry is 2 weeks, you get logged out after 2 weeks even if you regularly use the site. IIUC.
I think I haven't noticed logouts due to expired session, because on Healthchecks.io the expiry is 1 year, and I regularly log out and log into throwaway accounts for testing, so the 1 year expiry never comes around.
I'll look into implementing session refresh.