[PR #1021] [MERGED] Show warning if apprise is enabled but apprise package is not installed #1063

Closed
opened 2026-02-26 00:30:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/1021
Author: @aslirajesh
Created: 6/29/2024
Status: Merged
Merged: 7/4/2024
Merged by: @cuu508

Base: masterHead: fix/no-warning-on-apprise-install


📝 Commits (3)

  • 001c794 fix: show warning if apprise is enabled and not installed in environment
  • 45ce73c renamed appraise check register
  • 4fe4cc4 revert back changes in transport for apprise

📊 Changes

1 file changed (+23 additions, -0 deletions)

View changed files

📝 hc/api/apps.py (+23 -0)

📄 Description

Description

Added warning message if APPRISE_ENABLED is set to 'True' in settings, and python package 'apprise' is not installed.

Before changes APPRISE_ENABLED was being set to false without warning when apprise was not installed, even if it is enabled in settings.py

Issue

Fixes: #1020

Checklist

  • Issue Discussed
  • self-review
  • Format check of changed files with black

Screenshot

Screenshot 2024-06-29 122231


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/1021 **Author:** [@aslirajesh](https://github.com/aslirajesh) **Created:** 6/29/2024 **Status:** ✅ Merged **Merged:** 7/4/2024 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `fix/no-warning-on-apprise-install` --- ### 📝 Commits (3) - [`001c794`](https://github.com/healthchecks/healthchecks/commit/001c7945b55e46d64b56be1406e6993489e8815e) fix: show warning if apprise is enabled and not installed in environment - [`45ce73c`](https://github.com/healthchecks/healthchecks/commit/45ce73c8c5f8ee59811f1b29d862cfbdd753002b) renamed appraise check register - [`4fe4cc4`](https://github.com/healthchecks/healthchecks/commit/4fe4cc4f5d1cbf94bbcf355a5a37d300800bb304) revert back changes in transport for apprise ### 📊 Changes **1 file changed** (+23 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `hc/api/apps.py` (+23 -0) </details> ### 📄 Description ## Description Added warning message if APPRISE_ENABLED is set to 'True' in settings, and python package 'apprise' is not installed. Before changes APPRISE_ENABLED was being set to false without warning when apprise was not installed, even if it is enabled in settings.py ## Issue Fixes: #1020 ## Checklist - [ ] Issue Discussed - [X] self-review - [X] Format check of changed files with black ## Screenshot ![Screenshot 2024-06-29 122231](https://github.com/healthchecks/healthchecks/assets/22753800/304cf9df-df3c-4ea3-b5a5-b7f8723b2e13) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 00:30:47 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/healthchecks#1063
No description provided.