mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 23:15:49 +03:00
[GH-ISSUE #870] Integration Request: Webook running and stopped trigger similar to "hc_check_started" #612
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#612
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tekert on GitHub (Jul 31, 2023).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/870
This is a proposal to send webhooks when a check is running (initiated with
/start) and ended with a ping.Prometheus integration labels this as a metric named
hc_check_startedCurrently webhook only supports health checks triggers (UP or DOWN) status.
The proposal is to add another trigger for checks that are
startedand when they arestopped(finished)This is useful for sending push metrics without having to scrape prometheus endpoint at increased intervals for example, causing strain at both ends.
It would also be useful to have a placeholder for the
unique_keythat's exposed for the prometheus metric in the webhook, it's doesn't seem to be auuidor I'm mistaken?@cuu508 commented on GitHub (Aug 1, 2023):
Thanks for the suggestion!
The job of Healthchecks is to notify you when a job does not run or time. All notification methods, including webhooks, notify you on state changes (up -> down, and down -> up). They do not notify on "success" events, they do not notify on repeated "fail" events.
Notifying on "start" and "success" events would effectively be pass-through: when an event comes in, Healthchecks forwards it to the designated webhook address. I suggest you bypass Healthchecks and push from the client to the webhook target directly. If you also want Healthchecks monitoring, you could set up the client to ping Healthchecks and the webhook target in two separate HTTP requests.