[PR #32] [MERGED] defer inserting the password field into the dom #870

New issue

Closed

opened 2026-02-25 23:43:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:43:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/32
Author: @diwu1989
Created: 1/19/2016
Status: ✅ Merged
Merged: 1/19/2016
Merged by: @cuu508

Base: master ← Head: passwordManager

📝 Commits (1)

4558628 defer inserting the password field

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 static/js/login.js (+4 -2)

📄 Description

the password input field is hidden in the DOM, but that still means password managers will pick it up and insert into a password to use

if I have a password manager with multiple accounts + passwords, this can screw up the login experience

if the password input field is ONLY inserted into the DOM after the toggle has been checked, then the password managers will not be tricked.

I know this is an edge case with how browser password managers work, but the way I fixed it doesn't cause any interaction flow to existing users.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/32 **Author:** [@diwu1989](https://github.com/diwu1989) **Created:** 1/19/2016 **Status:** ✅ Merged **Merged:** 1/19/2016 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `passwordManager` --- ### 📝 Commits (1) - [`4558628`](https://github.com/healthchecks/healthchecks/commit/4558628ebf216467cf43a02154f303d5360fba8c) defer inserting the password field ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `static/js/login.js` (+4 -2) </details> ### 📄 Description the password input field is hidden in the DOM, but that still means password managers will pick it up and insert into a password to use if I have a password manager with multiple accounts + passwords, this can screw up the login experience if the password input field is ONLY inserted into the DOM after the toggle has been checked, then the password managers will not be tricked. I know this is an edge case with how browser password managers work, but the way I fixed it doesn't cause any interaction flow to existing users. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>