mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #429] Suggestion: report exit status #319
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#319
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @piramiday on GitHub (Sep 17, 2020).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/429
it would be useful to be able to report success or failure using only the exit status:
so that:
https://hc-ping.com/xxxyyyzzz/0means success,https://hc-ping.com/xxxyyyzzz/1and other numbers mean failure.this would make scripts shorter and would help to avoid the uglier
ifchecks on the exit status.ideally, it could be useful to store and show to the user the actual exit code
$?, but that's another matter because it requires changing a lot more.@cuu508 commented on GitHub (Sep 28, 2020):
That's a great suggestion, much cleaner than
iflogic.I'm planning on implementing it.
@cuu508 commented on GitHub (Oct 28, 2020):
This now implemented, deployed and ready for testing. Any and all feedback welcome!
@piramiday commented on GitHub (Oct 28, 2020):
happy to help! 🎉
@piramiday commented on GitHub (Nov 26, 2020):
just got my first failure of a check for which I use the
curl https://hc-ping.com/xxxyyyzzz/$?feature.from the dasboard I can read a message like "Ping #XX (received via the /fail endpoint)" -- that mentions the
/failendpoint incorrectly -- and I see no mention of the reported exit status, which would help in debugging.should I open up another issue with the feature suggestion of making the reported exit statuses transparent to the user?
IMHO even reporting the correct endpoint invoked by my curl would help, e.g.
/2 endpoint, no need to change graphics or add labels.@cuu508 commented on GitHub (Nov 27, 2020):
Thanks for the report @piramiday. There's a recent issue (#455) also about exposing the exit status, tlet's track this there.