mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 15:05:49 +03:00
[GH-ISSUE #583] Improve Zulip notifications #429
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#429
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @GhaziTriki on GitHub (Oct 30, 2021).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/583
Hello,
I would be good to improve Zulip notifications by adding the the ability to select the topic. As example we might have a checkbox "Automatic Topic" or if unchecked it will uncover the self-defined topic which is "alerts" in our case.
@cuu508 commented on GitHub (Oct 7, 2022):
Thanks for the suggestion. The Zulip integration currently generates topics in the form:
I want to make sure I understand the suggestion.
With "Automatic Topic" checked, the integration would work the same as currently, and use topics in one of the two above forms.
With "Automatic Topic" unchecked, the user would see a field to override the topic to a custom value, say, "alerts".
Is that correct?
@GhaziTriki commented on GitHub (Oct 7, 2022):
Hi @cuu508,
Let me explain the perspective of this issue. Currently we have about 150 "HC" tied to our Jenkins Jobs. The problem is that for every "hc" job we have 2 topics, on for UP and one for DOWN.
To compare it with what we have done with Zabbix, all zabbix notifications goes to the "alerts" topic. So instead of having 2x number of jobs as topics, we would have a single one were it is easier visually follow issues and search for history of a single item since searching in a single topic is visually better.
To avoid complaints from users having 2 topics per HC job; UP and DOWN; it would be possible to configure using a single topic named by the HC job owner.
Here is what we have visually now
@cuu508 commented on GitHub (Oct 7, 2022):
Thanks for the details, @GhaziTriki!
Mockup for the "Add Integration" form:
I'm not very familiar with Zulip, so please excuse the stupid question: Am I correct in thinking Topics are only relevant in Streams, and not in Private Messages?
@GhaziTriki commented on GitHub (Oct 9, 2022):
Hi @cuu508,
It looks perfect !! No question is stupid !
Indeed Topics are only relevant in Streams https://zulip.com/help/streams-and-topics but not in private messages https://zulip.com/help/private-messages
I am leaving a small doc here for people who wants to use the custom topic, they just need to move old messages to that new topic, empty topics will be automatically removed.
@cuu508 commented on GitHub (Oct 10, 2022):
@GhaziTriki I've now deployed this change to Healthchecks.io.