mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #308] When /fail endpoint is called, include request body in email alert #232
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#232
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cuu508 on GitHub (Nov 26, 2019).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/308
This would allow failing a check with an explicit message, and getting that message in email:
@dmhdev commented on GitHub (Mar 26, 2020):
Hello, this would be my first contribution but I have several years of experience in Python, Django and Linux Server Admin. Mind if I work on this issue?
@cuu508 commented on GitHub (Mar 27, 2020):
@vdaynm sure, sounds good!
I'd like to do a bigger revamp of the email message (#348) but we can do it a step at a time.
@dmhdev commented on GitHub (Apr 1, 2020):
Can you point me to the method or class that is sending the notification email, and should it be sent to all notification channels or only email?
@cuu508 commented on GitHub (Apr 1, 2020):
Here: https://github.com/healthchecks/healthchecks/blob/master/hc/api/transports.py#L57
Do you mean, should the request body be included in all notification templates? – No, each notification type would need to be considered separately. For example there's no way the request body will fit in in a SMS message.
@dlecan commented on GitHub (Jun 25, 2020):
I would like to implement the same feature, but for Slack notifications. Would you like to track this with another issue?
@lukastribus commented on GitHub (Oct 25, 2020):
I'm looking for this feature as well (in email, telegram, pushover integrations).
Seeing the request body without logging into to the dashboard would be extremely convenient, for obvious reasons.
@cuu508 commented on GitHub (Dec 26, 2020):
I've updated the email template to include the last ping body:
@dlecan, @lukastribus:
The ping body can be 10KB – it may need to be truncated to, say, 1KB for IM notifications. Let's track each in a separate issue. I'm happy to review PRs.