mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #410] [UI / UX] Show Request Body instead of "HTTP POST from <ip address>" message in Log display of checks dashboard. #308
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#308
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aeharvlee on GitHub (Aug 6, 2020).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/410
Hi, Thanks for the great project btw.
I'd like to suggest change of UI / UX in Log display of checks dashboard.
As-is: Logs displays preview message with "HTTP POST from "
To-be: Logs displays preview message with Request Body like "Temperature is now 35c. It looks good.".
In my humble opinion, "HTTP POST from " is quite useless.
That message does not help cron job administrator because what he wants is in Request Body.
So what do you think about replacing the preview message with the request body?
Many thanks to healthchecks team.
Kind regards.
@aeharvlee commented on GitHub (Aug 15, 2020):
As you can see, there are only meta messages of less important.
The hidden information is the IP address which is secret by the way.
@piramiday commented on GitHub (Sep 22, 2020):
as a workaround, you could pass your message as the User-Agent string instead of
python-requests/2.24.0...@aeharvlee commented on GitHub (Sep 23, 2020):
@piramiday
Thanks for your idea.
But i think changing user agent to custom logging is not good because the meaning of the user agent is lost.
It doesn't seem like a good idea in most case to directly touch the fields that mean the context of HTTP.
Nevertheless, the idea you presented seems like a good idea for the current version of the healthchecks.
@cuu508 commented on GitHub (Aug 27, 2021):
@aeharvlee if you go to the Log page (click "Show More..." under the Log section), it shows truncated request body as well.
You can also click on individual entries to get full details in a popup dialog.
It's a matter of opinion, and depends on the use case, but I feel that showing request method, IP and User-Agent in the Details page makes sense in the most cases. It helps you determine if:
For example, you can easily tell apart test pings sent from a browser, pings sent by link scanning bots, pings made from your workstation IP vs your server IPs.