[PR #42] [MERGED] [no-issue] add key shortcuts for editting search text #66

Closed
opened 2026-03-14 12:30:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/42
Author: @aome510
Created: 7/2/2021
Status: Merged
Merged: 7/2/2021
Merged by: @aome510

Base: mainHead: no-issue-add-text-cursor


📝 Commits (10+)

  • 23b0367 add cursor
  • c1f9e8f search view text with cursor looks kinda ok
  • 0ef6490 use query struct to display search view query
  • 0c07fa2 implement move_cursor_{left,right}
  • 07bdab0 add EditableTextView
  • fbf571f implement search view with EditableSearchView
  • be2e574 update documentation for edit keymap
  • d2ed948 clean up changes
  • 343f2c9 small renaming and remove debugs
  • e32c74a don't ignore up,down,tab,etc in search mode

📊 Changes

8 files changed (+262 additions, -118 deletions)

View changed files

📝 README.md (+11 -0)
📝 hackernews_tui/src/config/keybindings.rs (+28 -2)
📝 hackernews_tui/src/hn-tui-default.toml (+7 -0)
📝 hackernews_tui/src/utils.rs (+0 -1)
📝 hackernews_tui/src/view/list_view.rs (+0 -5)
📝 hackernews_tui/src/view/search_view.rs (+117 -105)
📝 hackernews_tui/src/view/text_view.rs (+98 -4)
📝 run_debug (+1 -1)

📄 Description

  • add EditableTextView (TextView with cursor and editing ability)
  • use EditableTextView to display search query in SearchView
  • refactor function declarations/key event handlers in search_view.rs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/42 **Author:** [@aome510](https://github.com/aome510) **Created:** 7/2/2021 **Status:** ✅ Merged **Merged:** 7/2/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `no-issue-add-text-cursor` --- ### 📝 Commits (10+) - [`23b0367`](https://github.com/aome510/hackernews-TUI/commit/23b0367be11611c1ba1d8c443f6c53712fd6ea12) add cursor - [`c1f9e8f`](https://github.com/aome510/hackernews-TUI/commit/c1f9e8f5ffbbe521e17aa53b12f26170d240be36) search view text with cursor looks kinda ok - [`0ef6490`](https://github.com/aome510/hackernews-TUI/commit/0ef6490cee942afd688e9e11afe94a5c820ee175) use query struct to display search view query - [`0c07fa2`](https://github.com/aome510/hackernews-TUI/commit/0c07fa281f07e2e257a489490c36cf036a4b32fc) implement move_cursor_{left,right} - [`07bdab0`](https://github.com/aome510/hackernews-TUI/commit/07bdab0546ccd6ff346077ab842ec3a252e7e677) add EditableTextView - [`fbf571f`](https://github.com/aome510/hackernews-TUI/commit/fbf571fab3f8bea3ede675b9b1fafbf982e4cd9d) implement search view with EditableSearchView - [`be2e574`](https://github.com/aome510/hackernews-TUI/commit/be2e57493b67af5be14cd199feb808898846b051) update documentation for edit keymap - [`d2ed948`](https://github.com/aome510/hackernews-TUI/commit/d2ed9488773480b7ad78e82c95d7c70ceb7a5783) clean up changes - [`343f2c9`](https://github.com/aome510/hackernews-TUI/commit/343f2c9778e11ea25385683cd3a2f1f4d065b509) small renaming and remove debugs - [`e32c74a`](https://github.com/aome510/hackernews-TUI/commit/e32c74abe8853ab8d57cbbd1d037f86cebd300cd) don't ignore up,down,tab,etc in search mode ### 📊 Changes **8 files changed** (+262 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+11 -0) 📝 `hackernews_tui/src/config/keybindings.rs` (+28 -2) 📝 `hackernews_tui/src/hn-tui-default.toml` (+7 -0) 📝 `hackernews_tui/src/utils.rs` (+0 -1) 📝 `hackernews_tui/src/view/list_view.rs` (+0 -5) 📝 `hackernews_tui/src/view/search_view.rs` (+117 -105) 📝 `hackernews_tui/src/view/text_view.rs` (+98 -4) 📝 `run_debug` (+1 -1) </details> ### 📄 Description - add `EditableTextView` (`TextView` with cursor and editing ability) - use `EditableTextView` to display search query in `SearchView` - refactor function declarations/key event handlers in `search_view.rs` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 12:30:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hackernews-TUI#66
No description provided.