[PR #17] [MERGED] [no-issue] change key bindings #42

New issue

Closed

opened 2026-03-14 12:29:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:29:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/17
Author: @aome510
Created: 3/18/2021
Status: ✅ Merged
Merged: 3/18/2021
Merged by: @aome510

Base: main ← Head: no-issue-change-key-bindings

📝 Commits (10+)

1098776 change status and footer layout
86b456d move key bindings for switching to story_view, search_view to global callback
5c7bbff improve error_view
3dcd89a make comment_view public
0c5b5e0 improve help_view
b77bb79 use ctrl instead of alt for leader key
c795dfc make buttons in footer work
d4db846 update README.md
477fefd fix highlighting
0c3683a change universal to global

📊 Changes

15 files changed (+152 additions, -186 deletions)

View changed files

📝 README.md (+10 -7)
📝 examples/assets/comment_view.png (+0 -0)
➕ examples/assets/footer_buttons.png (+0 -0)
📝 examples/assets/story_search_view.png (+0 -0)
📝 examples/assets/story_view.png (+0 -0)
📝 src/main.rs (+21 -7)
📝 src/prelude.rs (+1 -1)
📝 src/view/async_view.rs (+1 -2)
📝 src/view/comment_view.rs (+11 -39)
📝 src/view/error_view.rs (+8 -41)
📝 src/view/help_view.rs (+41 -34)
📝 src/view/mod.rs (+6 -5)
📝 src/view/search_view.rs (+13 -11)
📝 src/view/story_view.rs (+13 -17)
📝 src/view/utils.rs (+27 -22)

📄 Description

Brief description of changes

use ctrl as the leader key for global key shortcuts.
add HasHelpView trait.
move global key shorcut hanlders to main Cursive View.
change status bar and footer layout.
minor change on ErrorView layout.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/17 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/18/2021 **Status:** ✅ Merged **Merged:** 3/18/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `no-issue-change-key-bindings` --- ### 📝 Commits (10+) - [`1098776`](https://github.com/aome510/hackernews-TUI/commit/10987769588328b0ad202122cae95df71d270f81) change status and footer layout - [`86b456d`](https://github.com/aome510/hackernews-TUI/commit/86b456d84665d2ddd02f4b1ff966546904b30ffc) move key bindings for switching to story_view, search_view to global callback - [`5c7bbff`](https://github.com/aome510/hackernews-TUI/commit/5c7bbffb1d316dead0909f01cd69cbb51b293dbc) improve error_view - [`3dcd89a`](https://github.com/aome510/hackernews-TUI/commit/3dcd89a291e7d1ca2cf4a3927f9810b018e48d8c) make comment_view public - [`0c5b5e0`](https://github.com/aome510/hackernews-TUI/commit/0c5b5e074843a6a526d3a22072c1909d51b65b22) improve help_view - [`b77bb79`](https://github.com/aome510/hackernews-TUI/commit/b77bb792334ab368e0320004b71875837ce2ed72) use ctrl instead of alt for leader key - [`c795dfc`](https://github.com/aome510/hackernews-TUI/commit/c795dfc11e16d4ed5e7217e67052de083149a7a2) make buttons in footer work - [`d4db846`](https://github.com/aome510/hackernews-TUI/commit/d4db8464b418eebcebe1795661b1c38e212ccbe0) update README.md - [`477fefd`](https://github.com/aome510/hackernews-TUI/commit/477fefd11cf273f65012be89f1c759adc08a1c6c) fix highlighting - [`0c3683a`](https://github.com/aome510/hackernews-TUI/commit/0c3683a604b7fce0e5ef61fb03ffd720e134f5d7) change universal to global ### 📊 Changes **15 files changed** (+152 additions, -186 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+10 -7) 📝 `examples/assets/comment_view.png` (+0 -0) ➕ `examples/assets/footer_buttons.png` (+0 -0) 📝 `examples/assets/story_search_view.png` (+0 -0) 📝 `examples/assets/story_view.png` (+0 -0) 📝 `src/main.rs` (+21 -7) 📝 `src/prelude.rs` (+1 -1) 📝 `src/view/async_view.rs` (+1 -2) 📝 `src/view/comment_view.rs` (+11 -39) 📝 `src/view/error_view.rs` (+8 -41) 📝 `src/view/help_view.rs` (+41 -34) 📝 `src/view/mod.rs` (+6 -5) 📝 `src/view/search_view.rs` (+13 -11) 📝 `src/view/story_view.rs` (+13 -17) 📝 `src/view/utils.rs` (+27 -22) </details> ### 📄 Description **Brief description of changes** - use `ctrl` as the leader key for global key shortcuts. - add `HasHelpView` trait. - move global key shorcut hanlders to main `Cursive View`. - change status bar and footer layout. - minor change on `ErrorView` layout. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>