[PR #49] [MERGED] Multiple improvements #65

New issue

Closed

opened 2026-03-14 12:30:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:30:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/49
Author: @aome510
Created: 12/11/2021
Status: ✅ Merged
Merged: 12/12/2021
Merged by: @aome510

Base: main ← Head: improve-shortcut-handlers

📝 Commits (8)

665a111 simplify key parser and cleanup keybindings.rs
1abe3f8 not letting the child view to handle search-mode event in the search page
955875d Rewrite search view handlers (#48)
a60831c remove parking_lot
1cc5bfe update CIs
5643cc7 minor wording changes in the example configuration file
54ad562 remove scroll_offset config option and use a constant value 3
d09774b update README

📊 Changes

11 files changed (+268 additions, -362 deletions)

View changed files

📝 .github/workflows/audit-on-push.yml (+1 -0)
📝 .github/workflows/general.yml (+8 -1)
📝 README.md (+5 -19)
📝 examples/hn-tui.toml (+11 -17)
📝 hackernews_tui/src/client/mod.rs (+2 -1)
📝 hackernews_tui/src/config/keybindings.rs (+68 -62)
📝 hackernews_tui/src/config/mod.rs (+0 -2)
📝 hackernews_tui/src/view/article_view.rs (+2 -6)
📝 hackernews_tui/src/view/comment_view.rs (+2 -4)
📝 hackernews_tui/src/view/search_view.rs (+162 -249)
📝 hackernews_tui/src/view/text_view.rs (+7 -1)

📄 Description

Brief description of changes

simplify key (shortcut) parser
rewrite search view handlers (#48)
remove scroll_offset option
change the wordings in README and the example configuration file
update CI to not run audit on PR and general tests on PR Draft

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/49 **Author:** [@aome510](https://github.com/aome510) **Created:** 12/11/2021 **Status:** ✅ Merged **Merged:** 12/12/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `improve-shortcut-handlers` --- ### 📝 Commits (8) - [`665a111`](https://github.com/aome510/hackernews-TUI/commit/665a1110f48bea0fc5b3917eed58cbd5757a0ff4) simplify key parser and cleanup `keybindings.rs` - [`1abe3f8`](https://github.com/aome510/hackernews-TUI/commit/1abe3f8dbd6bbbb23263131e0bd47992d9d04545) not letting the child view to handle search-mode event in the search page - [`955875d`](https://github.com/aome510/hackernews-TUI/commit/955875dea48cf24126a7fcfc906b6e53a709216e) Rewrite search view handlers (#48) - [`a60831c`](https://github.com/aome510/hackernews-TUI/commit/a60831c86826a06ab7d9d858a08e3d5fdc77c514) remove parking_lot - [`1cc5bfe`](https://github.com/aome510/hackernews-TUI/commit/1cc5bfeb6349699d5c0a097b85e2f5c37b4a2673) update CIs - [`5643cc7`](https://github.com/aome510/hackernews-TUI/commit/5643cc758f84e0292e00fdb536bc1396fc6efa46) minor wording changes in the example configuration file - [`54ad562`](https://github.com/aome510/hackernews-TUI/commit/54ad562f93e107b7e1b95c0ff4214b590af71e95) remove `scroll_offset` config option and use a constant value `3` - [`d09774b`](https://github.com/aome510/hackernews-TUI/commit/d09774b729267315508610a84ab0c38f970b0e30) update README ### 📊 Changes **11 files changed** (+268 additions, -362 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/audit-on-push.yml` (+1 -0) 📝 `.github/workflows/general.yml` (+8 -1) 📝 `README.md` (+5 -19) 📝 `examples/hn-tui.toml` (+11 -17) 📝 `hackernews_tui/src/client/mod.rs` (+2 -1) 📝 `hackernews_tui/src/config/keybindings.rs` (+68 -62) 📝 `hackernews_tui/src/config/mod.rs` (+0 -2) 📝 `hackernews_tui/src/view/article_view.rs` (+2 -6) 📝 `hackernews_tui/src/view/comment_view.rs` (+2 -4) 📝 `hackernews_tui/src/view/search_view.rs` (+162 -249) 📝 `hackernews_tui/src/view/text_view.rs` (+7 -1) </details> ### 📄 Description ## Brief description of changes - simplify key (shortcut) parser - rewrite search view handlers (#48) - remove `scroll_offset` option - change the wordings in `README` and the example configuration file - update CI to not run audit on PR and general tests on PR Draft --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>