[PR #25] [MERGED] [#9] add support for switching between different Story Views #49

Closed
opened 2026-03-14 12:29:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/25
Author: @aome510
Created: 4/16/2021
Status: Merged
Merged: 4/16/2021
Merged by: @aome510

Base: mainHead: 9-more-story-view-2


📝 Commits (10+)

  • b689d12 use titlePrimary for key text
  • 75906a3 add tag, by_date to get stories
  • e3b5bd2 allow to config story_pooling
  • 09ac2f0 add global callbacks to switch between different story views
  • 636a886 add new/popular field to story_desc
  • 45bf8f6 handle story_pooling config options and switch by_date in StoryView
  • 77bbecc fix doc, config field
  • 74b8a90 make story_view in search view full height
  • d90ab32 add new key bindings to help_view
  • 48ef886 update README.md to include new StoryView, more project description

📊 Changes

12 files changed (+359 additions, -99 deletions)

View changed files

📝 README.md (+62 -16)
📝 examples/hn-tui.toml (+27 -7)
📝 src/config.rs (+35 -3)
📝 src/hn_client.rs (+23 -7)
📝 src/main.rs (+65 -2)
📝 src/view/async_view.rs (+20 -10)
📝 src/view/comment_view.rs (+1 -1)
📝 src/view/error_view.rs (+2 -2)
📝 src/view/help_view.rs (+13 -4)
📝 src/view/search_view.rs (+4 -4)
📝 src/view/story_view.rs (+89 -34)
📝 src/view/utils.rs (+18 -9)

📄 Description

Resolve #9

  • add more project descriptions in README
  • add support for jobs, ask_hn, all, show_hn Story Views:
    • modify documentation
    • modify examples
    • implement paging for above Views
    • implement switching between search and search_by_date for above Views
  • add more config options for story_pooling
  • add more config options for story_limit

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/25 **Author:** [@aome510](https://github.com/aome510) **Created:** 4/16/2021 **Status:** ✅ Merged **Merged:** 4/16/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `9-more-story-view-2` --- ### 📝 Commits (10+) - [`b689d12`](https://github.com/aome510/hackernews-TUI/commit/b689d12d3d4363a237094c258567063b089325f0) use titlePrimary for key text - [`75906a3`](https://github.com/aome510/hackernews-TUI/commit/75906a37645e2143e5adc9fe1fd9a8ccaa53e14b) add tag, by_date to get stories - [`e3b5bd2`](https://github.com/aome510/hackernews-TUI/commit/e3b5bd2594121e10708775d9da9b06214888121a) allow to config story_pooling - [`09ac2f0`](https://github.com/aome510/hackernews-TUI/commit/09ac2f03dc68f3f115c679a6223edd8db2ac1556) add global callbacks to switch between different story views - [`636a886`](https://github.com/aome510/hackernews-TUI/commit/636a8864bed64190fb658222e657c1fe03abc6d1) add new/popular field to story_desc - [`45bf8f6`](https://github.com/aome510/hackernews-TUI/commit/45bf8f635aeb9454ecc1e8b360de23053863b236) handle story_pooling config options and switch by_date in StoryView - [`77bbecc`](https://github.com/aome510/hackernews-TUI/commit/77bbecce7683b39974fa42a56dc028a65d5f24ae) fix doc, config field - [`74b8a90`](https://github.com/aome510/hackernews-TUI/commit/74b8a909b4912c8709ece67caac5f665711a8802) make story_view in search view full height - [`d90ab32`](https://github.com/aome510/hackernews-TUI/commit/d90ab32e00c177937e0f7fe4fc1a4d54851d515e) add new key bindings to help_view - [`48ef886`](https://github.com/aome510/hackernews-TUI/commit/48ef886a905a214a26966e8263b5351efce69ad4) update README.md to include new StoryView, more project description ### 📊 Changes **12 files changed** (+359 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+62 -16) 📝 `examples/hn-tui.toml` (+27 -7) 📝 `src/config.rs` (+35 -3) 📝 `src/hn_client.rs` (+23 -7) 📝 `src/main.rs` (+65 -2) 📝 `src/view/async_view.rs` (+20 -10) 📝 `src/view/comment_view.rs` (+1 -1) 📝 `src/view/error_view.rs` (+2 -2) 📝 `src/view/help_view.rs` (+13 -4) 📝 `src/view/search_view.rs` (+4 -4) 📝 `src/view/story_view.rs` (+89 -34) 📝 `src/view/utils.rs` (+18 -9) </details> ### 📄 Description Resolve #9 - add more project descriptions in `README` - add support for `jobs`, `ask_hn`, `all`, `show_hn` Story Views: - modify `documentation` - modify `examples` - implement paging for above Views - implement switching between `search` and `search_by_date` for above Views - add more config options for `story_pooling` - add more config options for `story_limit` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 12:29:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hackernews-TUI#49
No description provided.