[PR #18] [MERGED] [no-issue] code refactor part II #43

New issue

Closed

opened 2026-03-14 12:29:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:29:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/18
Author: @aome510
Created: 3/30/2021
Status: ✅ Merged
Merged: 3/30/2021
Merged by: @aome510

Base: main ← Head: no-issue-refactor-p2

📝 Commits (6)

b0237da change marco naming
3607f4e use ScrollListView, change order of some functions
9bfbbbf remove event_view
7e86355 add list_view
47a9283 handle {page}{up|down} as scrollView events
b4186d7 add back g,f

📊 Changes

8 files changed (+327 additions, -370 deletions)

View changed files

📝 src/prelude.rs (+6 -1)
📝 src/view/comment_view.rs (+128 -123)
➖ src/view/event_view.rs (+0 -152)
📝 src/view/help_view.rs (+0 -3)
➕ src/view/list_view.rs (+92 -0)
📝 src/view/mod.rs (+1 -1)
📝 src/view/search_view.rs (+8 -8)
📝 src/view/story_view.rs (+92 -82)

📄 Description

move functions used to parse CommentView and StoryView into the struct itself.
replace event_view.rs with a more specific and cleaner list_view.rs.
wrap CommentView and StoryView with ScrollListView instead of LinearLayout.
some code re-orderings.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/18 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/30/2021 **Status:** ✅ Merged **Merged:** 3/30/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `no-issue-refactor-p2` --- ### 📝 Commits (6) - [`b0237da`](https://github.com/aome510/hackernews-TUI/commit/b0237da9d3548befccf8b5b8f69bc676da029f89) change marco naming - [`3607f4e`](https://github.com/aome510/hackernews-TUI/commit/3607f4eb31ad34a650254b1a307a43d6f6c2040a) use ScrollListView, change order of some functions - [`9bfbbbf`](https://github.com/aome510/hackernews-TUI/commit/9bfbbbf9015024df94de81ec90179721a682b927) remove event_view - [`7e86355`](https://github.com/aome510/hackernews-TUI/commit/7e863551c3088ba30887cf458d61c0040953d587) add list_view - [`47a9283`](https://github.com/aome510/hackernews-TUI/commit/47a928382f771918f7b82009f1d0312f596f0222) handle {page}{up|down} as scrollView events - [`b4186d7`](https://github.com/aome510/hackernews-TUI/commit/b4186d7db8e14127aa8dfa6f22213ed5c140b6d8) add back g,f ### 📊 Changes **8 files changed** (+327 additions, -370 deletions) <details> <summary>View changed files</summary> 📝 `src/prelude.rs` (+6 -1) 📝 `src/view/comment_view.rs` (+128 -123) ➖ `src/view/event_view.rs` (+0 -152) 📝 `src/view/help_view.rs` (+0 -3) ➕ `src/view/list_view.rs` (+92 -0) 📝 `src/view/mod.rs` (+1 -1) 📝 `src/view/search_view.rs` (+8 -8) 📝 `src/view/story_view.rs` (+92 -82) </details> ### 📄 Description - move functions used to parse `CommentView` and `StoryView` into the struct itself. - replace `event_view.rs` with a more specific and cleaner `list_view.rs`. - wrap `CommentView` and `StoryView` with `ScrollListView` instead of `LinearLayout`. - some code re-orderings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>