[PR #110] Support proxy #111

Open
opened 2026-03-14 12:32:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/110
Author: @utensil
Created: 7/11/2025
Status: 🔄 Open

Base: mainHead: proxy


📝 Commits (2)

  • cd21d3f Add feature proxy-from-env for ureq
  • b1a8515 Also add feature socks-proxy to ureq

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 hackernews_tui/Cargo.toml (+1 -1)

📄 Description

Fixes #43

hackernews-TUI uses ureq 2.10.0 as its HTTP client library, it supports proxies via features proxy-from-env to load proxy settings from environment variable, and socks-proxy to support socks proxies.

ureq has 3.x and feature proxy-from-env is enabled by default there, but I didn't bump it to 3.x to avoid compatibility issues, only adding these 2 features.

Locally I've tested them to work very well with http and sock5 proxies.

For users really need things to work right now before this PR is merged, you may just

cargo install --git https://github.com/utensil/hackernews-TUI --branch proxy hackernews_tui --locked

So you are good to go!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/110 **Author:** [@utensil](https://github.com/utensil) **Created:** 7/11/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `proxy` --- ### 📝 Commits (2) - [`cd21d3f`](https://github.com/aome510/hackernews-TUI/commit/cd21d3f1da57af9c4093c73a6308d9f83cba4554) Add feature `proxy-from-env` for `ureq` - [`b1a8515`](https://github.com/aome510/hackernews-TUI/commit/b1a85159fa93b08a3b6a32c38c5931c24403fcc8) Also add feature `socks-proxy` to `ureq` ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `hackernews_tui/Cargo.toml` (+1 -1) </details> ### 📄 Description Fixes #43 hackernews-TUI uses [ureq 2.10.0](https://github.com/algesten/ureq/tree/2.10.0) as its HTTP client library, it supports proxies via features `proxy-from-env` to load proxy settings from environment variable, and `socks-proxy` to support socks proxies. `ureq` has 3.x and feature `proxy-from-env` is enabled by default there, but I didn't bump it to 3.x to avoid compatibility issues, only adding these 2 features. Locally I've tested them to work very well with http and sock5 proxies. For users really need things to work right now before this PR is merged, you may just ``` cargo install --git https://github.com/utensil/hackernews-TUI --branch proxy hackernews_tui --locked ``` So you are good to go! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hackernews-TUI#111
No description provided.