[PR #13] [MERGED] [#9] Add status bar, footer and help dialog #40

Closed
opened 2026-03-14 12:29:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/13
Author: @aome510
Created: 3/10/2021
Status: Merged
Merged: 3/10/2021
Merged by: @aome510

Base: mainHead: 9-more-supports-for-story-view


📝 Commits (8)

  • 0d75eac use macro for handle_digit
  • b1365d0 use {page}up,down for scrolling
  • 68d58da add help view
  • b0ed2b5 implment help dialog using LinearLayout::horizontal + TextView
  • e0a2368 refactor comment_view,story_view to add a status_bar
  • 909919f move construct_help_view as a method of Story/Comment View not a general trait method
  • 7ad3f0c add status bar and footer
  • ef070b6 remove focusable from text_view::TextView

📊 Changes

13 files changed (+283 additions, -85 deletions)

View changed files

📝 src/main.rs (+3 -1)
📝 src/prelude.rs (+1 -1)
📝 src/view/async_view.rs (+3 -2)
📝 src/view/comment_view.rs (+48 -45)
📝 src/view/error_view.rs (+1 -1)
📝 src/view/event_view.rs (+96 -25)
src/view/help_view.rs (+66 -0)
📝 src/view/mod.rs (+3 -2)
📝 src/view/story_view.rs (+30 -4)
📝 src/view/text_view.rs (+3 -3)
📝 src/view/theme.rs (+2 -0)
📝 src/view/utils.rs (+25 -0)
📝 theme.toml (+2 -1)

📄 Description

Part of #9:
Brief Description of changes

  • add status bar
  • add footer
  • add help dialog
  • some code refactor

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/13 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/10/2021 **Status:** ✅ Merged **Merged:** 3/10/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `9-more-supports-for-story-view` --- ### 📝 Commits (8) - [`0d75eac`](https://github.com/aome510/hackernews-TUI/commit/0d75eac44f4cfc2fb9bb03c568307a644dfe45a5) use macro for handle_digit - [`b1365d0`](https://github.com/aome510/hackernews-TUI/commit/b1365d0c28070c70f149445244277ba4c1dd6898) use {page}up,down for scrolling - [`68d58da`](https://github.com/aome510/hackernews-TUI/commit/68d58dab448b379db809a7ee5836696f5286f0bf) add help view - [`b0ed2b5`](https://github.com/aome510/hackernews-TUI/commit/b0ed2b59e1208e13e160657ef9074657b64e618a) implment help dialog using LinearLayout::horizontal + TextView - [`e0a2368`](https://github.com/aome510/hackernews-TUI/commit/e0a2368aa1e672154c0864bca1e33d4add17876b) refactor comment_view,story_view to add a status_bar - [`909919f`](https://github.com/aome510/hackernews-TUI/commit/909919f1d2c8c5a0ea09685478aeb1488d225129) move construct_help_view as a method of Story/Comment View not a general trait method - [`7ad3f0c`](https://github.com/aome510/hackernews-TUI/commit/7ad3f0c85d066b47e91b265cc9dbcdd0ea8d1823) add status bar and footer - [`ef070b6`](https://github.com/aome510/hackernews-TUI/commit/ef070b69dd296a4c8bd83ce2383ecb9575c50b19) remove focusable from text_view::TextView ### 📊 Changes **13 files changed** (+283 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+3 -1) 📝 `src/prelude.rs` (+1 -1) 📝 `src/view/async_view.rs` (+3 -2) 📝 `src/view/comment_view.rs` (+48 -45) 📝 `src/view/error_view.rs` (+1 -1) 📝 `src/view/event_view.rs` (+96 -25) ➕ `src/view/help_view.rs` (+66 -0) 📝 `src/view/mod.rs` (+3 -2) 📝 `src/view/story_view.rs` (+30 -4) 📝 `src/view/text_view.rs` (+3 -3) 📝 `src/view/theme.rs` (+2 -0) 📝 `src/view/utils.rs` (+25 -0) 📝 `theme.toml` (+2 -1) </details> ### 📄 Description Part of #9: **Brief Description of changes** - add status bar - add footer - add help dialog - some code refactor --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 12:29:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hackernews-TUI#40
No description provided.