[PR #76] [MERGED] Match nginx parity: skip hidden files for include globs #75

New issue

Closed

opened 2026-02-28 01:20:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:20:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tufanbarisyildirim/gonginx/pull/76
Author: @tufanbarisyildirim
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @tufanbarisyildirim

Base: master ← Head: fix/issue-64-include-glob-hidden-parity

📝 Commits (1)

fde1b87 Match nginx include glob behavior for hidden files

📊 Changes

2 files changed (+82 additions, -0 deletions)

View changed files

📝 parser/parser.go (+23 -0)
📝 parser/parser_test.go (+59 -0)

📄 Description

Summary

make include parsing skip hidden path matches when the include path uses glob metacharacters
keep explicit hidden-file includes working (only wildcard includes are filtered)
add parser regression tests for both glob and explicit include cases

Testing

go test ./parser -run 'TestParser_IncludeGlobSkipsHiddenFiles|TestParser_IncludeExplicitHiddenFile'
go test ./parser
make test

Closes #64

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tufanbarisyildirim/gonginx/pull/76 **Author:** [@tufanbarisyildirim](https://github.com/tufanbarisyildirim) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@tufanbarisyildirim](https://github.com/tufanbarisyildirim) **Base:** `master` ← **Head:** `fix/issue-64-include-glob-hidden-parity` --- ### 📝 Commits (1) - [`fde1b87`](https://github.com/tufanbarisyildirim/gonginx/commit/fde1b87c7de5ae9a4d0bee8c1cf55a016184ead2) Match nginx include glob behavior for hidden files ### 📊 Changes **2 files changed** (+82 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `parser/parser.go` (+23 -0) 📝 `parser/parser_test.go` (+59 -0) </details> ### 📄 Description ## Summary - make include parsing skip hidden path matches when the include path uses glob metacharacters - keep explicit hidden-file includes working (only wildcard includes are filtered) - add parser regression tests for both glob and explicit include cases ## Testing - `go test ./parser -run 'TestParser_IncludeGlobSkipsHiddenFiles|TestParser_IncludeExplicitHiddenFile'` - `go test ./parser` - `make test` Closes #64 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>