[PR #61] [MERGED] #54 Keep parameters in their relative lines when in multi-line configuration. #64

New issue

Closed

opened 2026-02-28 01:20:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:20:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tufanbarisyildirim/gonginx/pull/61
Author: @mofantor
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/20/2024
Merged by: @tufanbarisyildirim

Base: master ← Head: keep-data-multi-line-#54

📝 Commits (2)

e25cfaa 1. Migrate all directive parameters to the Parameter object
8489fce fix: resolve linter warnings in statement.go

📊 Changes

26 files changed (+179 additions, -91 deletions)

View changed files

📝 config/block_test.go (+6 -6)
📝 config/directive.go (+2 -2)
📝 config/http.go (+2 -2)
📝 config/include.go (+1 -1)
📝 config/location.go (+3 -3)
📝 config/lua_block.go (+2 -2)
📝 config/server.go (+2 -2)
📝 config/statement.go (+32 -1)
📝 config/upstream.go (+3 -3)
📝 config/upstream_server.go (+11 -9)
📝 dumper/block_test.go (+19 -11)
📝 dumper/config_test.go (+7 -4)
📝 dumper/directive_test.go (+17 -17)
📝 dumper/dumper.go (+12 -1)
📝 dumper/http_test.go (+2 -2)
📝 dumper/include_test.go (+1 -1)
📝 dumper/location_test.go (+1 -1)
📝 dumper/server_test.go (+2 -2)
📝 dumper/upstream_server_test.go (+3 -3)
📝 dumper/upstream_test.go (+9 -9)

...and 6 more files

📄 Description

Migrate all directive parameters to the Parameter object
The Parameter object stores the relative line index to the directive, allowing the dump to retain the original layout
During parsing, obtain and store the relative line index of parameters to the directive
During dump, restore the original relative line index

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tufanbarisyildirim/gonginx/pull/61 **Author:** [@mofantor](https://github.com/mofantor) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/20/2024 **Merged by:** [@tufanbarisyildirim](https://github.com/tufanbarisyildirim) **Base:** `master` ← **Head:** `keep-data-multi-line-#54` --- ### 📝 Commits (2) - [`e25cfaa`](https://github.com/tufanbarisyildirim/gonginx/commit/e25cfaa673a75ba99e463d55d17256cc2fcddc0a) 1. Migrate all directive parameters to the Parameter object - [`8489fce`](https://github.com/tufanbarisyildirim/gonginx/commit/8489fce6245d54eee2b046d430430bdf2743fd46) fix: resolve linter warnings in statement.go ### 📊 Changes **26 files changed** (+179 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `config/block_test.go` (+6 -6) 📝 `config/directive.go` (+2 -2) 📝 `config/http.go` (+2 -2) 📝 `config/include.go` (+1 -1) 📝 `config/location.go` (+3 -3) 📝 `config/lua_block.go` (+2 -2) 📝 `config/server.go` (+2 -2) 📝 `config/statement.go` (+32 -1) 📝 `config/upstream.go` (+3 -3) 📝 `config/upstream_server.go` (+11 -9) 📝 `dumper/block_test.go` (+19 -11) 📝 `dumper/config_test.go` (+7 -4) 📝 `dumper/directive_test.go` (+17 -17) 📝 `dumper/dumper.go` (+12 -1) 📝 `dumper/http_test.go` (+2 -2) 📝 `dumper/include_test.go` (+1 -1) 📝 `dumper/location_test.go` (+1 -1) 📝 `dumper/server_test.go` (+2 -2) 📝 `dumper/upstream_server_test.go` (+3 -3) 📝 `dumper/upstream_test.go` (+9 -9) _...and 6 more files_ </details> ### 📄 Description 1. Migrate all directive parameters to the Parameter object 2. The Parameter object stores the relative line index to the directive, allowing the dump to retain the original layout 3. During parsing, obtain and store the relative line index of parameters to the directive 4. During dump, restore the original relative line index --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>