[PR #72] [MERGED] Fix include parser error handling #72

New issue

Closed

opened 2026-02-28 01:20:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:20:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tufanbarisyildirim/gonginx/pull/72
Author: @tufanbarisyildirim
Created: 6/20/2025
Status: ✅ Merged
Merged: 6/20/2025
Merged by: @tufanbarisyildirim

Base: master ← Head: codex/remove-panic-and-return-error-in-parseinclude

📝 Commits (1)

37695dc fix parser include error handling

📊 Changes

2 files changed (+36 additions, -2 deletions)

View changed files

📝 parser/parser.go (+5 -2)
📝 parser/parser_test.go (+31 -0)

📄 Description

Summary

avoid panicking when include parser cannot be created
return the error unless WithSkipIncludeParsingErr is enabled
add tests verifying new error behavior

Testing

make test SHELL=/bin/bash

https://chatgpt.com/codex/tasks/task_e_685527120c448329a2385c62199bc9aa

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tufanbarisyildirim/gonginx/pull/72 **Author:** [@tufanbarisyildirim](https://github.com/tufanbarisyildirim) **Created:** 6/20/2025 **Status:** ✅ Merged **Merged:** 6/20/2025 **Merged by:** [@tufanbarisyildirim](https://github.com/tufanbarisyildirim) **Base:** `master` ← **Head:** `codex/remove-panic-and-return-error-in-parseinclude` --- ### 📝 Commits (1) - [`37695dc`](https://github.com/tufanbarisyildirim/gonginx/commit/37695dcc763339b239866a39f5a57e8c0ad766f8) fix parser include error handling ### 📊 Changes **2 files changed** (+36 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `parser/parser.go` (+5 -2) 📝 `parser/parser_test.go` (+31 -0) </details> ### 📄 Description ## Summary - avoid panicking when include parser cannot be created - return the error unless `WithSkipIncludeParsingErr` is enabled - add tests verifying new error behavior ## Testing - `make test SHELL=/bin/bash` ------ https://chatgpt.com/codex/tasks/task_e_685527120c448329a2385c62199bc9aa --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>