[PR #32] [MERGED] Handle errors go way & handle unexpected EOF in blocks #51

New issue

Closed

opened 2026-02-28 01:20:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:20:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tufanbarisyildirim/gonginx/pull/32
Author: @tufanbarisyildirim
Created: 12/15/2023
Status: ✅ Merged
Merged: 12/22/2023
Merged by: @tufanbarisyildirim

Base: master ← Head: v2

📝 Commits (6)

106216a handle errors go way, init fixing #31
eeb298e add option to skip comments
5bfd15d handle unexpected eof in block parsing
6a7cfcb fix building issues for examples
619c2d8 validate known directives
460e47b delete duplicate directives, fix tests, make linter happy

📊 Changes

16 files changed (+1031 additions, -109 deletions)

View changed files

📝 Makefile (+3 -0)
📝 block.go (+1 -0)
📝 dumper.go (+3 -1)
📝 examples/adding-server/main.go (+4 -1)
📝 examples/formatting/main.go (+4 -1)
📝 examples/update-directive/main.go (+4 -1)
📝 http.go (+1 -0)
📝 lua_block.go (+1 -0)
📝 parser/parser.go (+82 -48)
📝 parser/parser_test.go (+60 -48)
➕ parser/valid_directives.go (+731 -0)
➕ testdata/issues/31.conf (+115 -0)
📝 upstream.go (+6 -1)
📝 upstream_server.go (+2 -2)
📝 upstream_server_test.go (+4 -1)
📝 upstream_test.go (+10 -5)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tufanbarisyildirim/gonginx/pull/32 **Author:** [@tufanbarisyildirim](https://github.com/tufanbarisyildirim) **Created:** 12/15/2023 **Status:** ✅ Merged **Merged:** 12/22/2023 **Merged by:** [@tufanbarisyildirim](https://github.com/tufanbarisyildirim) **Base:** `master` ← **Head:** `v2` --- ### 📝 Commits (6) - [`106216a`](https://github.com/tufanbarisyildirim/gonginx/commit/106216ab8f187c89ff2262030350dfb061473cdc) handle errors go way, init fixing #31 - [`eeb298e`](https://github.com/tufanbarisyildirim/gonginx/commit/eeb298e37ddfc50879c45a2687ae7a541c4c3991) add option to skip comments - [`5bfd15d`](https://github.com/tufanbarisyildirim/gonginx/commit/5bfd15d29c5ac203800717243eaade05a9ad509b) handle unexpected eof in block parsing - [`6a7cfcb`](https://github.com/tufanbarisyildirim/gonginx/commit/6a7cfcb00d1d37a471ce5cca6e8d70556c771946) fix building issues for examples - [`619c2d8`](https://github.com/tufanbarisyildirim/gonginx/commit/619c2d846f3b23812e4bcca83b8a84ec0e16abab) validate known directives - [`460e47b`](https://github.com/tufanbarisyildirim/gonginx/commit/460e47b9f30a545a2495f449843208492a2db735) delete duplicate directives, fix tests, make linter happy ### 📊 Changes **16 files changed** (+1031 additions, -109 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+3 -0) 📝 `block.go` (+1 -0) 📝 `dumper.go` (+3 -1) 📝 `examples/adding-server/main.go` (+4 -1) 📝 `examples/formatting/main.go` (+4 -1) 📝 `examples/update-directive/main.go` (+4 -1) 📝 `http.go` (+1 -0) 📝 `lua_block.go` (+1 -0) 📝 `parser/parser.go` (+82 -48) 📝 `parser/parser_test.go` (+60 -48) ➕ `parser/valid_directives.go` (+731 -0) ➕ `testdata/issues/31.conf` (+115 -0) 📝 `upstream.go` (+6 -1) 📝 `upstream_server.go` (+2 -2) 📝 `upstream_server_test.go` (+4 -1) 📝 `upstream_test.go` (+10 -5) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>