[GH-ISSUE #73] slow dumper.DumpLuaBlock #31

New issue

Closed

opened 2026-02-28 01:20:36 +03:00 by kerem · 2 comments

kerem commented

2026-02-28 01:20:36 +03:00

Owner

Originally created by @gtors on GitHub (Dec 12, 2025).
Original GitHub issue: https://github.com/tufanbarisyildirim/gonginx/issues/73

dumper.DumpLuaBlock takes ~200 ms for just 2 lines of Lua — the bottleneck is the formatter.

Could formatting be optional? For example:

WithLuaFormatting(false) (default true), or
WithLuaFormatter(customFormatter) to allow plugging in a faster/no-op implementation.

Originally created by @gtors on GitHub (Dec 12, 2025). Original GitHub issue: https://github.com/tufanbarisyildirim/gonginx/issues/73 `dumper.DumpLuaBlock` takes ~200 ms for just 2 lines of Lua — the bottleneck is the formatter. Could formatting be optional? For example: - `WithLuaFormatting(false)` (default `true`), or - `WithLuaFormatter(customFormatter)` to allow plugging in a faster/no-op implementation. <img width="1856" height="362" alt="Image" src="https://github.com/user-attachments/assets/4ad0ba11-341d-4e59-bcca-3a579454b6e0" />

kerem closed this issue

2026-02-28 01:20:36 +03:00

kerem commented

2026-02-28 01:20:36 +03:00

Author

Owner

@gtors commented on GitHub (Dec 12, 2025):

Fix it locally by replacing package in go.mod

replace github.com/imega/luaformatter => ./luaformatter_stub

Content of ./luaformatter_stub/formatter/formatter.go:

package formatter

import (
	"io"
)

type Config struct {
	IndentSize    any
	MaxLineLength any
	Highlight     any
	Spaces        any
	Alignment     any
}

func DefaultConfig() Config {
	return Config{}
}

func Format(c Config, b []byte, w io.Writer) error {
	_, err := w.Write(b)
	return err
}

@gtors commented on GitHub (Dec 12, 2025): Fix it locally by replacing package in `go.mod` ``` replace github.com/imega/luaformatter => ./luaformatter_stub ``` Content of `./luaformatter_stub/formatter/formatter.go`: ```go package formatter import ( "io" ) type Config struct { IndentSize any MaxLineLength any Highlight any Spaces any Alignment any } func DefaultConfig() Config { return Config{} } func Format(c Config, b []byte, w io.Writer) error { _, err := w.Write(b) return err } ```

kerem commented

2026-02-28 01:20:36 +03:00

Author

Owner

@tufanbarisyildirim commented on GitHub (Feb 20, 2026):

Implemented in #77: Lua formatting is now optional (WithLuaFormatting(false)) and pluggable via WithLuaFormatter(...).

@tufanbarisyildirim commented on GitHub (Feb 20, 2026): Implemented in #77: Lua formatting is now optional (`WithLuaFormatting(false)`) and pluggable via `WithLuaFormatter(...)`.

kerem referenced this issue

2026-02-28 01:20:42 +03:00

[PR #32] [MERGED] Handle errors go way & handle unexpected EOF in blocks #51