[GH-ISSUE #28] NewParser use os.Open and how to close it #12

Closed
opened 2026-02-28 01:20:29 +03:00 by kerem · 3 comments
Owner

Originally created by @ixqbar on GitHub (Oct 30, 2023).
Original GitHub issue: https://github.com/tufanbarisyildirim/gonginx/issues/28

NewParser use os.Open and how to close it ?

image
Originally created by @ixqbar on GitHub (Oct 30, 2023). Original GitHub issue: https://github.com/tufanbarisyildirim/gonginx/issues/28 NewParser use os.Open and how to close it ? <img width="706" alt="image" src="https://github.com/tufanbarisyildirim/gonginx/assets/960982/a23c8001-c4fc-4512-8398-3928b1855d59">
kerem 2026-02-28 01:20:29 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@tufanbarisyildirim commented on GitHub (Oct 30, 2023):

good catch with my rookie mistake, I would happily merge if you want to fix it @ixqbar .

<!-- gh-comment-id:1784806145 --> @tufanbarisyildirim commented on GitHub (Oct 30, 2023): good catch with my rookie mistake, I would happily merge if you want to fix it @ixqbar .
Author
Owner

@berejant commented on GitHub (Nov 15, 2023):

@tufanbarisyildirim I pushed merge request to fix it. #29

<!-- gh-comment-id:1813329687 --> @berejant commented on GitHub (Nov 15, 2023): @tufanbarisyildirim I pushed merge request to fix it. #29
Author
Owner

@tufanbarisyildirim commented on GitHub (Nov 16, 2023):

Thanks @berejant

<!-- gh-comment-id:1814726425 --> @tufanbarisyildirim commented on GitHub (Nov 16, 2023): Thanks @berejant
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/gonginx#12
No description provided.