mirror of
https://github.com/tufanbarisyildirim/gonginx.git
synced 2026-04-27 00:35:51 +03:00
[GH-ISSUE #57] Suggest lowering the golang version statement in your project #28
Labels
No labels
bug
enhancement
good first issue
pull-request
question
v2
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/gonginx#28
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sharelinux on GitHub (Nov 27, 2024).
Original GitHub issue: https://github.com/tufanbarisyildirim/gonginx/issues/57
It is recommended to lower the golang version declaration in your project, as defined here in go.mod.
This project uses golang 1.23.3, which was released in August 2024 and is too new to be tested and found that this project does not reference any third party packages or system libraries that need to be upgraded to 1.23.3
If a large project uses this as a base package, it is too risky to upgrade golang to the latest version 1.23.3 directly after referencing this project.
After testing, we found that modifying the go.mod version in this project such as: go 1.21, and test all the unit tests are no exception. Recommended to use golang 1.21.0 version, this version also supports toolchain, in order to follow up on the dependency package management upgrade is also supported.
As a base library, upgrading the golang version of this needs to be done very carefully. I hope this suggestion will be adopted.
Fix I'll also mention a PR and hopefully take that comment on board.