mirror of
https://github.com/devgianlu/go-librespot.git
synced 2026-04-26 05:15:49 +03:00
[GH-ISSUE #141] API: relative POST player/volume seems to be broken #87
Labels
No labels
bug
enhancement
pull-request
spotify-side
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/go-librespot#87
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @2opremio on GitHub (Nov 12, 2024).
Original GitHub issue: https://github.com/devgianlu/go-librespot/issues/141
I am using the Alsa mixer with the following configuration:
I am also using the
POST player/volumeendpoint to increase/decrease the volume in a relative manner:To increase:
To decrease:
However, the volume only increases 1 step up or down (it doesn't continue increasing or decreasing upon multiple API calls).
Also, I get lots of this spurious (and seemly incorrect) warnings:
@2opremio commented on GitHub (Nov 12, 2024):
BTW, setting the volume from an external Spotify client does seem to change the Alsa mixer volume correctly.
@2opremio commented on GitHub (Nov 12, 2024):
Also, this is on
0.1.2(I haven't checked other versions)@2opremio commented on GitHub (Nov 12, 2024):
If you turn down the volume very slowly (approx one change for second) then it works. This makes it unusable though.
I bet is that https://github.com/devgianlu/go-librespot/pull/86/commits/4ad9ae18b9b228a56e0e69ab640100e530dcf4ac caused this (CC @aykevl )
It's worth noting that if you you request volume changes faster than 1 per second, the volume doesn't update at all.
I think that the mixer update frequency should be independent of the frequency we send updates back to Spotify.
@aykevl commented on GitHub (Nov 13, 2024):
I can confirm this issue with the PulseAudio output so it's not related to the ALSA mixer.
@aykevl commented on GitHub (Nov 13, 2024):
Wrote a fix: https://github.com/devgianlu/go-librespot/pull/144
This fix actually simplifies the code because there's no real reason why the volume needs to be kept outside the player state.