[PR #91] [MERGED] fix: small fixes to accesspoint connect retry logic #202

New issue

Closed

opened 2026-02-28 14:26:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/91
Author: @aykevl
Created: 9/10/2024
Status: ✅ Merged
Merged: 9/10/2024
Merged by: @devgianlu

Base: master ← Head: fix-ap-connect-attempts

📝 Commits (1)

273897b fix: small fixes to accesspoint connect retry logic

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 ap/ap.go (+3 -3)

📄 Description

Immediately cancel the context after establishing a connection. It is only used while connecting, so can be cancelled at that point.
Fix error message when all 6 attempts have failed.
Use log.WithError to log an error.

See #87

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/91 **Author:** [@aykevl](https://github.com/aykevl) **Created:** 9/10/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `fix-ap-connect-attempts` --- ### 📝 Commits (1) - [`273897b`](https://github.com/devgianlu/go-librespot/commit/273897b3efca02386b9f8e9e4592e2821a110c3a) fix: small fixes to accesspoint connect retry logic ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ap/ap.go` (+3 -3) </details> ### 📄 Description * Immediately cancel the context after establishing a connection. It is only used while connecting, so can be cancelled at that point. * Fix error message when all 6 attempts have failed. * Use log.WithError to log an error. See #87 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>