starred/go-librespot

Fork 0

mirror of https://github.com/devgianlu/go-librespot.git synced 2026-04-26 05:15:49 +03:00

[GH-ISSUE #100] Proposal: move configuration to config directory #69

New issue

Closed

opened 2026-02-28 14:25:06 +03:00 by kerem · 5 comments

kerem commented

2026-02-28 14:25:06 +03:00

Owner

Originally created by @aykevl on GitHub (Sep 22, 2024).
Original GitHub issue: https://github.com/devgianlu/go-librespot/issues/100

Right now, go-librespot reads configuration and credentials from the current working directory (unless specified otherwise). I propose we use the following scheme instead:

Configuration is read from ~/.config/go-librespot/config.yml. The file is the same as it currently is.

Credentials are stored in a new state file, in ~/.config/go-librespot/state.json. The file looks like this:

{
  "credentials": {
    "username": "...",
    "data": "..."
  },
  "device_id": "..."
}

The config directory is configurable with a flag, defaulting to UserConfigDir() + "/go-librespot" so it also uses the appropriate directory on other OSes.

There are a few reasons why I think this is a good idea:

I think the current directory is a bad place to store configuration. Maybe it's fine on a headless system, but at least the way I use go-librespot is on a regular user account (with config directory available).
More state needs to be saved, such as ZeroConfig credentials. I also have an issue that Spotify keeps defaulting to "Let others Jam on this speaker" which I suspect is because the device ID is regenerated each time.

@devgianlu if you agree with this scheme I'd like to implement this (but asking here first before I put a lot of work into it).

Originally created by @aykevl on GitHub (Sep 22, 2024). Original GitHub issue: https://github.com/devgianlu/go-librespot/issues/100 Right now, go-librespot reads configuration and credentials from the current working directory (unless specified otherwise). I propose we use the following scheme instead: * Configuration is read from ~/.config/go-librespot/config.yml. The file is the same as it currently is. * Credentials are stored in a new state file, in ~/.config/go-librespot/state.json. The file looks like this: ```json { "credentials": { "username": "...", "data": "..." }, "device_id": "..." } ``` * The config directory is configurable with a flag, defaulting to `UserConfigDir() + "/go-librespot"` so it also uses the appropriate directory on other OSes. There are a few reasons why I think this is a good idea: * I think the current directory is a bad place to store configuration. Maybe it's fine on a headless system, but at least the way I use go-librespot is on a regular user account (with config directory available). * More state needs to be saved, such as [ZeroConfig credentials](https://github.com/devgianlu/go-librespot/issues/81). I also have an issue that Spotify keeps defaulting to "Let others Jam on this speaker" which I suspect is because the device ID is regenerated each time. @devgianlu if you agree with this scheme I'd like to implement this (but asking here first before I put a lot of work into it).

kerem

2026-02-28 14:25:06 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-02-28 14:25:07 +03:00

Author

Owner

@Willyarma commented on GitHub (Sep 22, 2024):

Its more useful to me the way it is for my application, is there a way we can have both? perhaps with a command line option?

@Willyarma commented on GitHub (Sep 22, 2024): Its more useful to me the way it is for my application, is there a way we can have both? perhaps with a command line option?

kerem commented

2026-02-28 14:25:07 +03:00

Author

Owner

@aykevl commented on GitHub (Sep 23, 2024):

@Willyarma yes, if there's a flag to set the config directory then you can set it to use the current working directory.

@aykevl commented on GitHub (Sep 23, 2024): @Willyarma yes, if there's a flag to set the config directory then you can set it to use the current working directory.

kerem commented

2026-02-28 14:25:07 +03:00

Author

Owner

@Willyarma commented on GitHub (Sep 23, 2024):

I already made a request in #80 for command line options. Its loosly related to this.
I was thinking about creating the config file dynamically on the fly then realised if I launch all instances in parallel then that wont work. A command line path / filename for different config files would though.

Edit: Looks like it was already done, sorry I didnt realise.

@Willyarma commented on GitHub (Sep 23, 2024): I already made a request in #80 for command line options. Its loosly related to this. I was thinking about creating the config file dynamically on the fly then realised if I launch all instances in parallel then that wont work. A command line path / filename for different config files would though. Edit: Looks like it was already done, sorry I didnt realise.

kerem commented

2026-02-28 14:25:07 +03:00

Author

Owner

@devgianlu commented on GitHub (Sep 23, 2024):

@aykevl This sounds like a great idea, especially in tackling #81. I have recently refactored the configuration code to use koanf so it's a little bit nicer, but this is even better.

@devgianlu commented on GitHub (Sep 23, 2024): @aykevl This sounds like a great idea, especially in tackling #81. I have recently refactored the configuration code to use `koanf` so it's a little bit nicer, but this is even better.

kerem commented

2026-02-28 14:25:07 +03:00

Author

Owner

@aykevl commented on GitHub (Sep 29, 2024):

Proposal is implemented in #103 so closing.

@aykevl commented on GitHub (Sep 29, 2024): Proposal is implemented in #103 so closing.

kerem referenced this issue

2026-02-28 14:26:11 +03:00

[PR #69] [MERGED] fix: delegate starting receiver loops to caller #190