[PR #69] [MERGED] fix: delegate starting receiver loops to caller #190

New issue

Closed

opened 2026-02-28 14:26:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/69
Author: @silenium-dev
Created: 8/18/2024
Status: ✅ Merged
Merged: 8/20/2024
Merged by: @devgianlu

Base: master ← Head: master

📝 Commits (10+)

3679080 feat: start work on exposing Dealer.Connect()
236d7ce feat: implement dealer.Connect()
ef4802b feat: move running ping ticker and opening connection from NewAccesspoint() to Accesspoint.Connect()
4f80b86 feat: move dealer.Connect() out of session, let caller handle it
4e6fe9a feat: move running accesspoint.pongAckTicker() to startReceiving()
5cfdf6d debug: add ping-pong trace logging for dealer and accesspoint
f9f4efe feat: move running dealer.pingTicker() to dealer.startReceiving() and move initializing lastPong to startReceiving
b29b1b0 fix: reset dealer.lastPong on reconnect, increase pong tardiness interval to pingInterval+timeout
668ce4f fix: return immediately from Close() if connection not open
f695e05 fix: only close conn on receive loop termination when not stopping, remove read lock around recvLoop read

📊 Changes

4 files changed (+117 additions, -65 deletions)

View changed files

📝 ap/ap.go (+46 -32)
📝 cmd/daemon/player.go (+5 -0)
📝 dealer/dealer.go (+58 -28)
📝 session/session.go (+8 -5)

📄 Description

fixes #68

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/69 **Author:** [@silenium-dev](https://github.com/silenium-dev) **Created:** 8/18/2024 **Status:** ✅ Merged **Merged:** 8/20/2024 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`3679080`](https://github.com/devgianlu/go-librespot/commit/367908065888e8c4c7d0142f02a7203d25d05f96) feat: start work on exposing Dealer.Connect() - [`236d7ce`](https://github.com/devgianlu/go-librespot/commit/236d7ce6d726e60fe5603471d2aebb1c841f3e5a) feat: implement dealer.Connect() - [`ef4802b`](https://github.com/devgianlu/go-librespot/commit/ef4802b235a0b0decf741d37fbaf7060ceab55a9) feat: move running ping ticker and opening connection from NewAccesspoint() to Accesspoint.Connect() - [`4f80b86`](https://github.com/devgianlu/go-librespot/commit/4f80b865df74d61b786ccc2a2f37169b3a1b3d8d) feat: move dealer.Connect() out of session, let caller handle it - [`4e6fe9a`](https://github.com/devgianlu/go-librespot/commit/4e6fe9af166c0336fe63ed4f4276c1a1961b9903) feat: move running accesspoint.pongAckTicker() to startReceiving() - [`5cfdf6d`](https://github.com/devgianlu/go-librespot/commit/5cfdf6d9b289c65087fe3517c5bbc63fa9121221) debug: add ping-pong trace logging for dealer and accesspoint - [`f9f4efe`](https://github.com/devgianlu/go-librespot/commit/f9f4efeb532d8d631b14e1b25db932b177f04096) feat: move running dealer.pingTicker() to dealer.startReceiving() and move initializing lastPong to startReceiving - [`b29b1b0`](https://github.com/devgianlu/go-librespot/commit/b29b1b0e9e9c39936242319c48314ec094bd43a7) fix: reset dealer.lastPong on reconnect, increase pong tardiness interval to pingInterval+timeout - [`668ce4f`](https://github.com/devgianlu/go-librespot/commit/668ce4ffeb2ed08a1112e13b8d5d1056f1de184e) fix: return immediately from Close() if connection not open - [`f695e05`](https://github.com/devgianlu/go-librespot/commit/f695e0549347852397707421c31efd69e87b8976) fix: only close conn on receive loop termination when not stopping, remove read lock around recvLoop read ### 📊 Changes **4 files changed** (+117 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `ap/ap.go` (+46 -32) 📝 `cmd/daemon/player.go` (+5 -0) 📝 `dealer/dealer.go` (+58 -28) 📝 `session/session.go` (+8 -5) </details> ### 📄 Description fixes #68 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>