[PR #217] [MERGED] fix: use next from the set_queue command to retain queue order #252

Closed
opened 2026-02-28 14:26:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/217
Author: @tooxo
Created: 9/19/2025
Status: Merged
Merged: 9/19/2025
Merged by: @devgianlu

Base: masterHead: queue


📝 Commits (2)

  • de5e6f0 fix: use next from the set_queue command to retain queue order
  • 8538ec6 fix: adapt for if the currently playing song was queued

📊 Changes

3 files changed (+42 additions, -18 deletions)

View changed files

📝 cmd/daemon/controls.go (+7 -7)
📝 cmd/daemon/player.go (+1 -1)
📝 tracks/tracks.go (+34 -10)

📄 Description

See: #216

Not entirely sure, if the "nil-by-default" parameter is how one would do this in go, but this seemed to be the simplest solution to me.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/217 **Author:** [@tooxo](https://github.com/tooxo) **Created:** 9/19/2025 **Status:** ✅ Merged **Merged:** 9/19/2025 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `queue` --- ### 📝 Commits (2) - [`de5e6f0`](https://github.com/devgianlu/go-librespot/commit/de5e6f052ba8b05fdf44ca476b2e82f3741baba6) fix: use next from the set_queue command to retain queue order - [`8538ec6`](https://github.com/devgianlu/go-librespot/commit/8538ec62a805efed5239d8cc702eb9e09250b2c5) fix: adapt for if the currently playing song was queued ### 📊 Changes **3 files changed** (+42 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `cmd/daemon/controls.go` (+7 -7) 📝 `cmd/daemon/player.go` (+1 -1) 📝 `tracks/tracks.go` (+34 -10) </details> ### 📄 Description See: #216 Not entirely sure, if the "nil-by-default" parameter is how one would do this in go, but this seemed to be the simplest solution to me. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:26:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-librespot#252
No description provided.