[PR #113] [MERGED] fix: put previous tracks in the right order #216

Closed
opened 2026-02-28 14:26:17 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/113
Author: @aykevl
Created: 10/3/2024
Status: Merged
Merged: 10/3/2024
Merged by: @devgianlu

Base: masterHead: fix-PrevTracks-order


📝 Commits (1)

  • 07bb1fd fix: put previous tracks in the right order

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 tracks/tracks.go (+4 -0)

📄 Description

These tracks aren't directly visible, but they are visible (for a short bit) when pressing the 'prev' button.

Previously this would always show the first track in an album, which is incorrect. This fix makes sure that 'prev' actually shows the previous track.

Perhaps slices.Reverse is not the right way to do this, please let me know if there's a better way.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/113 **Author:** [@aykevl](https://github.com/aykevl) **Created:** 10/3/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `fix-PrevTracks-order` --- ### 📝 Commits (1) - [`07bb1fd`](https://github.com/devgianlu/go-librespot/commit/07bb1fdf415398f63484f7ef41bd6fdf29c0da97) fix: put previous tracks in the right order ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `tracks/tracks.go` (+4 -0) </details> ### 📄 Description These tracks aren't directly visible, but they are visible (for a short bit) when pressing the 'prev' button. Previously this would always show the first track in an album, which is incorrect. This fix makes sure that 'prev' actually shows the previous track. Perhaps `slices.Reverse` is not the right way to do this, please let me know if there's a better way. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:26:17 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-librespot#216
No description provided.