[PR #219] [MERGED] Test setup and minor fixes #251

New issue

Closed

opened 2026-02-28 14:26:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/219
Author: @devgianlu
Created: 9/19/2025
Status: ✅ Merged
Merged: 9/19/2025
Merged by: @devgianlu

Base: master ← Head: tests

📝 Commits (10+)

14582df chore: rename paged_list to paged-list
8dea99f feat: add NullLogger
5acbd87 test: introduce mockery
74f21dc test: improve tracks paged list unit tests
1593855 chore: enable tests in CI
e65d82a chore: rename chunked_reader to chunked-reader
6c794f0 fix: clamp audio chunk HTTP range request
37a5392 feat: add Close method to HttpChunkedReader
2681783 test: add HttpChunkedReader integration tests
56b5db8 test: add LatencyReader unit tests

📊 Changes

15 files changed (+1735 additions, -251 deletions)

View changed files

📝 .github/workflows/build_test.yml (+1 -1)
➕ .mockery.yaml (+13 -0)
📝 audio/chunked-reader.go (+27 -2)
➕ audio/chunked-reader_integration_test.go (+327 -0)
➕ audio/chunked-reader_internal_test.go (+93 -0)
➕ audio/latency_test.go (+102 -0)
📝 gen.go (+1 -0)
📝 go.mod (+5 -0)
📝 go.sum (+4 -0)
📝 logger.go (+17 -0)
➕ mock_Logger.go (+655 -0)
➕ mock_PageResolver.go (+108 -0)
📝 tracks/paged-list.go (+0 -0)
➕ tracks/paged-list_internal_test.go (+382 -0)
➖ tracks/paged_list_test.go (+0 -248)

📄 Description

This PR adds some test infrastructure as well as some new tests for pagedList, HttpChunkedReader and LatencyReader.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/219 **Author:** [@devgianlu](https://github.com/devgianlu) **Created:** 9/19/2025 **Status:** ✅ Merged **Merged:** 9/19/2025 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `tests` --- ### 📝 Commits (10+) - [`14582df`](https://github.com/devgianlu/go-librespot/commit/14582dfc340a8f4b9ca2b0acd19eda5cb3908a64) chore: rename paged_list to paged-list - [`8dea99f`](https://github.com/devgianlu/go-librespot/commit/8dea99f068265b96cb2d240b8973d5780da17b06) feat: add NullLogger - [`5acbd87`](https://github.com/devgianlu/go-librespot/commit/5acbd8724043ce201f64d997dc8a2281f86971f7) test: introduce mockery - [`74f21dc`](https://github.com/devgianlu/go-librespot/commit/74f21dcb5680e9e4e8575b885e24462864499a3f) test: improve tracks paged list unit tests - [`1593855`](https://github.com/devgianlu/go-librespot/commit/159385522eb7dc4d2f560cb43840c46590020d65) chore: enable tests in CI - [`e65d82a`](https://github.com/devgianlu/go-librespot/commit/e65d82ac510a86c22da783ebfa69376fba6e1196) chore: rename chunked_reader to chunked-reader - [`6c794f0`](https://github.com/devgianlu/go-librespot/commit/6c794f0561d300d335aaf77d2f7a04931d1d6e4f) fix: clamp audio chunk HTTP range request - [`37a5392`](https://github.com/devgianlu/go-librespot/commit/37a539269099d4557497772f1624b762f1605019) feat: add `Close` method to `HttpChunkedReader` - [`2681783`](https://github.com/devgianlu/go-librespot/commit/2681783439807054a3e43016c30f16e8dd263c34) test: add `HttpChunkedReader` integration tests - [`56b5db8`](https://github.com/devgianlu/go-librespot/commit/56b5db8be2b986653cce25eed781f6d8c97e6c1b) test: add `LatencyReader` unit tests ### 📊 Changes **15 files changed** (+1735 additions, -251 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build_test.yml` (+1 -1) ➕ `.mockery.yaml` (+13 -0) 📝 `audio/chunked-reader.go` (+27 -2) ➕ `audio/chunked-reader_integration_test.go` (+327 -0) ➕ `audio/chunked-reader_internal_test.go` (+93 -0) ➕ `audio/latency_test.go` (+102 -0) 📝 `gen.go` (+1 -0) 📝 `go.mod` (+5 -0) 📝 `go.sum` (+4 -0) 📝 `logger.go` (+17 -0) ➕ `mock_Logger.go` (+655 -0) ➕ `mock_PageResolver.go` (+108 -0) 📝 `tracks/paged-list.go` (+0 -0) ➕ `tracks/paged-list_internal_test.go` (+382 -0) ➖ `tracks/paged_list_test.go` (+0 -248) </details> ### 📄 Description This PR adds some test infrastructure as well as some new tests for `pagedList`, `HttpChunkedReader` and `LatencyReader`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>