mirror of
https://github.com/devgianlu/go-librespot.git
synced 2026-04-25 21:05:47 +03:00
[PR #117] [MERGED] fix: initialize vorbis stream on the first read #219
Labels
No labels
bug
enhancement
pull-request
spotify-side
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/go-librespot#219
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/devgianlu/go-librespot/pull/117
Author: @aykevl
Created: 10/6/2024
Status: ✅ Merged
Merged: 10/6/2024
Merged by: @devgianlu
Base:
master← Head:fix-play-start-stutter-2📝 Commits (1)
ee50dfffix: initialize vorbis stream on the first read📊 Changes
1 file changed (+6 additions, -2 deletions)
View changed files
📝
vorbis/decoder.go(+6 -2)📄 Description
This fixes a stutter that can be heard on some songs, where it would initialize the stream, seek to a different position (or 0), and then continue. This is most audible on tracks that immediately start playing audio without fade-in.
This is probably a better fix than #116.
fixes #115
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.