[GH-ISSUE #222] Special character is synced wrong #213

Closed
opened 2026-02-25 22:36:29 +03:00 by kerem · 4 comments
Owner

Originally created by @linuxrecon on GitHub (Jan 15, 2019).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/222

Software versions

  • Browser: Firefox 64
  • Nextcloud: 15.0.0
  • Nextcloud Bookmarks app: 0.15.1
  • Floccus: 3.2.3
  • Floccus sync method: nextcloud-folders

Steps to reproduce

We are using OTRS. A lot of the users are bookmarking OTRS links to tickets. A direct link to a ticket does look like this: https://my.otrs.dom/index.pl?Action=AgentTicketZoom;TicketID=707128

  1. Bookmark a URL with a ; character. It doesn't matter if this bookmark is created within NextCloud Bookmarks or within your browser.
  2. Let Floccus sync that Bookmark.
  3. Try to open the bookmark within your browser.
  4. The ; character (and all special characters after this one) will be transformed to something like '%3B'.

Expected outcome

The URL shouldn't be transformed by Floccer. Otherwise the links ware mostly likely broken.

Actual outcome

It seems like that Floccer has problems with syncing URLs with ';' in it. With that being said, adding a URL with a ';' character to NextCloud Bookmarks from the webinterface and opening the URL from the webinterface works fine. Using the AddOn FreedomMarks with Firefox also works as expected. However, FreedomMarks does not actually sync the bookmarks rather than accessing them directly through the NextCloud API.

Originally created by @linuxrecon on GitHub (Jan 15, 2019). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/222 <!-- Hello there! Thank you for providing feedback! Please answer the below questions to allow for as smooth a process of tackling the issue as possible :) (Note: Everything surrounded by arrows, like this text for example, will not be visible.) --> ### Software versions - Browser: Firefox 64 - Nextcloud: 15.0.0 - Nextcloud Bookmarks app: 0.15.1 - Floccus: 3.2.3 - Floccus sync method: nextcloud-folders ### Steps to reproduce We are using OTRS. A lot of the users are bookmarking OTRS links to tickets. A direct link to a ticket does look like this: https://my.otrs.dom/index.pl?Action=AgentTicketZoom;TicketID=707128 1. Bookmark a URL with a ; character. It doesn't matter if this bookmark is created within NextCloud Bookmarks or within your browser. 2. Let Floccus sync that Bookmark. 3. Try to open the bookmark within your browser. 4. The ; character (and all special characters after this one) will be transformed to something like '%3B'. ### Expected outcome The URL shouldn't be transformed by Floccer. Otherwise the links ware mostly likely broken. ### Actual outcome It seems like that Floccer has problems with syncing URLs with ';' in it. With that being said, adding a URL with a ';' character to NextCloud Bookmarks from the webinterface and opening the URL from the webinterface works fine. Using the AddOn FreedomMarks with Firefox also works as expected. However, FreedomMarks does not actually sync the bookmarks rather than accessing them directly through the NextCloud API. <!-- Thanks! Now, hit Submit and wait for a reply :) -->
kerem 2026-02-25 22:36:29 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@marcelklehr commented on GitHub (Jan 15, 2019):

Thank you for the feedback! This definitely appears to be a bug. I have opened an issue with the library used for URL normalization in floccus and will report back here.

<!-- gh-comment-id:454501412 --> @marcelklehr commented on GitHub (Jan 15, 2019): Thank you for the feedback! This definitely appears to be a bug. I have [opened an issue with the library used for URL normalization](https://github.com/sindresorhus/normalize-url/issues/85) in floccus and will report back here.
Author
Owner

@marcelklehr commented on GitHub (Feb 5, 2019):

I guess I will write my own normalization library...

<!-- gh-comment-id:460841353 --> @marcelklehr commented on GitHub (Feb 5, 2019): I guess I will write my own normalization library...
Author
Owner

@marcelklehr commented on GitHub (Feb 7, 2019):

This should be fixed in the next release

<!-- gh-comment-id:461490143 --> @marcelklehr commented on GitHub (Feb 7, 2019): This should be fixed in the next release
Author
Owner

@github-actions[bot] commented on GitHub (Mar 21, 2023):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:1477569895 --> @github-actions[bot] commented on GitHub (Mar 21, 2023): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/floccus#213
No description provided.