starred/floccus

Fork 0

mirror of https://github.com/floccusaddon/floccus.git synced 2026-04-25 14:16:12 +03:00

[GH-ISSUE #231] Bug: Bookmarks get Duplicated #222

New issue

Closed

opened 2026-02-25 22:36:31 +03:00 by kerem · 6 comments

kerem commented

2026-02-25 22:36:31 +03:00

Owner

Originally created by @gohrner on GitHub (Feb 14, 2019).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/231

Floccus 3.2.4 / Chromium 71.

Floccus dropped / deleted my XBEL-on-WebDAV account during some update (it should not silently do so, but that's another story...), so I had to recreate it.

Afterwards Floccus duplicated about half of my bookmark entries. The duplicates were identical except for a present or missing trailing slash in the URL. (I'm not sure if the original URLs had a trailing slash or were lacking it.)

Possibly, this bug was introduced by the introduction of a new URL normalisation library I read about in the Changelog? ("FIX: Use a different URL normalization library")

It was quite some work to clean up the mess afterwards... :-(

Originally created by @gohrner on GitHub (Feb 14, 2019). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/231 Floccus 3.2.4 / Chromium 71. Floccus dropped / deleted my XBEL-on-WebDAV account during some update (it should not silently do so, but that's another story...), so I had to recreate it. Afterwards Floccus duplicated about half of my bookmark entries. The duplicates were identical except for a present or missing trailing slash in the URL. (I'm not sure if the original URLs had a trailing slash or were lacking it.) Possibly, this bug was introduced by the introduction of a new URL normalisation library I read about in the Changelog? ("FIX: Use a different URL normalization library") It was quite some work to clean up the mess afterwards... :-(

kerem

2026-02-25 22:36:31 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-25 22:36:31 +03:00

Author

Owner

@marcelklehr commented on GitHub (Feb 14, 2019):

Hey,

I'm sorry you had to go through that. The cause of this indeed appears to be the changed normalization algorithm. The old algorithm apparently always removed trailing slashes, which made floccus treat http://google.com/foo/ the same as http://google.com/foo (this is not a good idea, but that's a separate point). The algorithm had other problematic properties, which forced me to switch to a different one.

The new algorithm is more gentle and doesn't butcher URLs so they're unusable in the worst case. The downside of this is that butchered URLs that went through the old algorithm are treated as different from the unbutchered URLs, which causes semantic duplicates, i.e. two bookmarks that (in most cases) eventually resolve to the same web page even though they have different URLs.

Sorting this out is a one-time thing as the problem resulted from changing the normalization algorithm, not from syncing in itself. I'll try and come up with a fix for this, though, as it is indeed quite cumbersome to sort this out.

@marcelklehr commented on GitHub (Feb 14, 2019): Hey, I'm sorry you had to go through that. The cause of this indeed appears to be the changed normalization algorithm. The old algorithm apparently always removed trailing slashes, which made floccus treat `http://google.com/foo/` the same as `http://google.com/foo` (this is not a good idea, but that's a separate point). The algorithm had other problematic properties, which forced me to switch to a different one. The new algorithm is more gentle and doesn't butcher URLs so they're unusable in the worst case. The downside of this is that butchered URLs that went through the old algorithm are treated as different from the unbutchered URLs, which causes semantic duplicates, i.e. two bookmarks that (in most cases) eventually resolve to the same web page even though they have different URLs. Sorting this out is a one-time thing as the problem resulted from changing the normalization algorithm, not from syncing in itself. I'll try and come up with a fix for this, though, as it is indeed quite cumbersome to sort this out.

kerem commented

2026-02-25 22:36:31 +03:00

Author

Owner

@Tank-Missile commented on GitHub (Feb 14, 2019):

Ah, that explains why I'm seeing duplicate bookmarks with incorrect URLs. I might just have to nuke everything in my bookmarks app and start over.

@Tank-Missile commented on GitHub (Feb 14, 2019): Ah, that explains why I'm seeing duplicate bookmarks with incorrect URLs. I might just have to nuke everything in my bookmarks app and start over.

kerem commented

2026-02-25 22:36:31 +03:00

Author

Owner

@marcelklehr commented on GitHub (Feb 14, 2019):

You can also wait for the next release which should sort out the butchered URLs

@marcelklehr commented on GitHub (Feb 14, 2019): You can also wait for the next release which should sort out the butchered URLs

kerem commented

2026-02-25 22:36:31 +03:00

Author

Owner

@marcelklehr commented on GitHub (Feb 14, 2019):

Here we go.

@marcelklehr commented on GitHub (Feb 14, 2019): Here we go.

kerem commented

2026-02-25 22:36:31 +03:00

Author

Owner

@marcelklehr commented on GitHub (Feb 15, 2019):

Did that help?

@marcelklehr commented on GitHub (Feb 15, 2019): Did that help?

kerem commented

2026-02-25 22:36:31 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Mar 21, 2023):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions[bot] commented on GitHub (Mar 21, 2023): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#222

No description provided.

Rows
Columns