mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #216] Floccus 3.2.0: Error when deleting bookmarks #207
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#207
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gohrner on GitHub (Dec 21, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/216
@gohrner commented on GitHub (Dec 21, 2018):
Syncing does not work any more at all afterwards, I keep getting this error message even after a browser restart.
Is there any way to get Floccus working again besides removing the account and sync from scratch?
@gohrner commented on GitHub (Dec 21, 2018):
Additional information:
As it wasn't possible to delete bookmarks with the previous Floccus release, but moving bookmarks worked just fine, I moved all bookmarks I wanted to get rid of to a "Trashbin" folder I created for this purpose.
As the "cannot delete bookmarks" bug #213 was supposed to be fixed in Floccus 3.2.0, the first thing I tried was to delete the whole "Trashbin" folder and sync - which led to the exception shown above.
@gohrner commented on GitHub (Dec 21, 2018):
(BTW, as mentioned in my comment in #213, this all happens with a WebDAV/xbel sync setup.)
@marcelklehr commented on GitHub (Dec 21, 2018):
Mh. I cannot reproduce this. Deleting a folder with bookmarks synced via WebDAV works for me. Could you share more details and/or provide the debug logs (optionally via private mail, to avoid leakage of sensitive data).
@marcelklehr commented on GitHub (Dec 21, 2018):
Mmh. Ticking the 'Sync from scratch' option to reset the cache might work. Can you give it a try?
@gohrner commented on GitHub (Dec 23, 2018):
This helped, after resetting the cache, syncing works again and the deleted bookmarks disappeared after deleting them again.
@gohrner commented on GitHub (Dec 23, 2018):
Deletion behaviour is still somewhat hard to understand for me... If a add a bookmark on Computer A (Chrome and Floccus 3.2.0) and sync, and sync on Computer B (Firefox, still Floccus 3.1.15, no update to 3.2.0 available so far), it appears there.
If I then delete it on Computer A and sync, and sync on Computer B, the new bookmark is still there. It disappeared in the server-side XBEL file, though.
Deleting the bookmark in Computer B and syncing again will make it re-appear on Computer B (?!?), but it's still not present in the XBEL file...
Is it supposed to behave this way? When will the deleted bookmark actually disappear from Computer B?
@marcelklehr commented on GitHub (Dec 23, 2018):
@gohrner This is most probably due to the fact that you still have the old floccus version on computer B. Mozilla's addon review team seem to be on holiday at the moment :/
@gohrner commented on GitHub (Dec 23, 2018):
Ok, then I'll just wait for the update to show up and test again. Then I'll just close this bug as a "hickup"?
@gohrner commented on GitHub (Dec 29, 2018):
Meanwhile the Firefox addon also got its update to 3.2.1. A first try to synchronize lead to the error message:
Folder ordering is missing some of the folder's children
Afterwards the "Trashbin" folder, which had been deleted in Chrome an in the XBEL file on the server, reappeared. (But the error message vanished.)
I deleted the "Trasbin" folder again and we'll see what happens...
@marcelklehr commented on GitHub (Dec 30, 2018):
Did it come back?
@gohrner commented on GitHub (Jan 1, 2019):
I wish you a happy new year!
Unfortunately yes - it reappeared in Firefox. We then pressed "sync" there to see what happens, and now Chrome throws an Error on sync again: "Folder ordering is missing some of the folder's children"... The Chrome Add-On currently is on 3.2.2, I cannot check the FF addon version at the moment, but it's at least 3.2.1 or also 3.2.2.
@marcelklehr commented on GitHub (Jan 1, 2019):
Happy new year! 🎉
@gohrner commented on GitHub (Jan 2, 2019):
Sent logs by mail.
@gohrner commented on GitHub (Jan 2, 2019):
Must be a demonstration effect, but finally the folder also got deleted on the Firefox side and is still gone in Chrome... Must be the demonstration effect. I didn't do anything further besides waiting.
@marcelklehr commented on GitHub (Jan 2, 2019):
hah, I think I was able to reproduce this, though. Let's see if the next version fixes things for you as well.
@gohrner commented on GitHub (Jan 2, 2019):
Great, I'm curious. :)
@erdnussflips commented on GitHub (Jan 4, 2019):
I'm getting also "Folder ordering is missing some of the folder's children".
Waiting for the next version. :)
@marcelklehr commented on GitHub (Jan 4, 2019):
The new version is released.
@erdnussflips commented on GitHub (Jan 7, 2019):
For me, the new version doesn't fix the problem. Still getting "Folder ordering is missing some of the folder's children". 😥
@marcelklehr commented on GitHub (Jan 7, 2019):
Ooph. This bug is tough.
So, according to @gohrner the general pattern is the following:
At the moment @erdnussflips seems to be at the last step. I think, it is possible that the last step persists even though the original bug is fixed. Could you reset the cache on both clients and thus start from scratch? The folder in question will likely be created on all clients again, but then it'd be interesting to see if the first error reappears and if any other errors occur at all.
@marcelklehr commented on GitHub (Feb 7, 2019):
Any news on this?
@gohrner commented on GitHub (Feb 12, 2019):
Just noticed that Floccus apparently lost my account completely sometime recently - so no wonder I did not see any sync failures. ;) No account is configured at all at the moment... :-/
(The sync failures also seem to have been more or less resolved by your previous bugfix releases.)
@marcelklehr commented on GitHub (Feb 12, 2019):
This is all very strange. 🤔
How did it go on your end @erdnussflips?
@erdnussflips commented on GitHub (Feb 13, 2019):
Hi @marcelklehr, i reseted both clients but, the error still appeared.
At the end I exported my bookmarks through the browser. Then I removed all the bookmarks from all synced browsers, reseted the cache and let floccus sync the empty bookmark list.
After that I reimported all my bookmarks in browser 1 and started floccus sync. Then I started floccus sync in browser 2. Now the problem is gone.
@marcelklehr commented on GitHub (Mar 22, 2019):
Alrighty, next iteration: I've reproduced this again and will release the fixes in the next patch, today.
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.