mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 06:35:59 +03:00
[GH-ISSUE #192] Folder ordering is missing some of the folder's children #183
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#183
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jlbprof on GitHub (Nov 13, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/192
Just started this morning, I think Floccus was updated this morning as well.
floccus-3.1.2-2018-11-13.log
Software versions
Steps to reproduce
Expected outcome
Should not get an error
...
Actual outcome
Error
...
@jlbprof commented on GitHub (Nov 13, 2018):
@jlbprof commented on GitHub (Nov 13, 2018):
Line 158 in the source view, is where it throws the error.
@jlbprof commented on GitHub (Nov 13, 2018):
I am looking at the XBEL file from a previous sync, it is a folder that has not changed in a long time. It is a bunch of recipes.
@jlbprof commented on GitHub (Nov 13, 2018):
It missed the first line of that folder, sorry.
@jlbprof commented on GitHub (Nov 13, 2018):
hmm it will not show the folder line interesting
NOTE: I added the slash folder, it is not there in the file
@jlbprof commented on GitHub (Nov 13, 2018):
There is probably something wrong with that data, but not sure.
@marcelklehr commented on GitHub (Nov 13, 2018):
Mh. In you XBEL data there 141 bookmarks, while floccus wants to order 160. Can you check the floccus array for duplicates? That would indicate a bug. How many bookmarks are in the associated folder in the browser?
On first glance, I see that there are some duplicate bookmarks in your XBEL, but I don't think that should be a problem.
@nicuh commented on GitHub (Nov 13, 2018):
I had the same issue which appeared after updating to version 3.1.1 (Firefox 63.0).
There was a bookmark duplicated about 10 times. After deleting the copies problem was fixed.
@jlbprof commented on GitHub (Nov 13, 2018):
I found the duplicates and removed them.
The procedure to clean this up is difficult. I had to:
So it took me a few times to clean that up.
Thank you, feel free to close this.
@marcelklehr commented on GitHub (Nov 13, 2018):
@nicuh Ah, that's bad. I assume the duplicates were created by earlier floccus versions.
Glad it works now!
@nicuh commented on GitHub (Nov 14, 2018):
@marcelklehr Yes I assume so, because now I see them on a different device running version 3.0.10 of the plugin where the sync was still working.
Thanks for the great work, I love that I can sync bookmarks with my own cloud!
@jlbprof For me it wasn't so complicated, I just deleted the duplicate bookmarks from Firefox and then forced sync using reset cache.
@minj commented on GitHub (Nov 14, 2018):
Having the same problem here...
@TheInsomniac commented on GitHub (Nov 15, 2018):
This issue is occurring for me in Chrome 70 and NextCloud via WebDav.
I have gone so far as to delete the xbel file and attempt to sync from scratch but am still met with this error.
@marcelklehr commented on GitHub (Nov 16, 2018):
@TheInsomniac Did you tick the checkbox for reset cache as well?
@ploink commented on GitHub (Feb 24, 2019):
I got the same problem.
Using Opera and WebDAV.
From a folder in "Bookmarks bar" I removed some bookmarks.
Then I moved the entire folder to "Other bookmarks" en the next sync threw the error.
The deleted bookmarks returned.
Perhaps the folder id remains the same when moving and floccus gets confused because it is found in a different location then expected?
@marcelklehr commented on GitHub (Mar 1, 2019):
Thanks for persisting with this! I've finally found the culprit I think and this should be fixed by
8380ce10c1, now. (fingers-crossed 🙂 )@marcelklehr commented on GitHub (Mar 2, 2019):
v3.2.7 has the fix, now. Feedback is appreciated :)
@minj commented on GitHub (Mar 2, 2019):
the error went away after sync, we'll see, if it holds up
@ploink commented on GitHub (Mar 3, 2019):
Thanks for the update.
I have been playing with it for a while, cleaning up some bookmarks until I hit these errors:
Perhaps things go wrong because I am using Opera?
Number 1 started when I deleted a subfolder and then its parent, then I caused 2 and 3 by trying to reverse/fix it. Then the errors dissapeared by making sure those folders were restored and trash emptied on both my computers. The Trash folder often seems to be the problem for me.
Now I think I have seen all of those before so I believe this is not caused by the new version.
Somehow I fail to repoduce it.
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.