mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 06:35:59 +03:00
[GH-ISSUE #201] Cannot read property 'id' of undefined #192
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#192
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Tank-Missile on GitHub (Nov 26, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/201
Software versions
I'm using a provider (https://cloud.disroot.org), so I'm not sure how to check the bookmarks app version. I'm not even sure if the nextcloud version (14) is completely accurate either.
Steps to reproduce
Just attempting a manual sync will cause the error.
Expected outcome
My bookmarks sync with my account and show up in the bookmarks app.
Actual outcome
Cannot read property 'id' of undefined.
@marcelklehr commented on GitHub (Nov 26, 2018):
Can you provide the debug log?
@Tank-Missile commented on GitHub (Nov 26, 2018):
This is all the log provides.
@marcelklehr commented on GitHub (Nov 26, 2018):
Which sync method do you use (webdav/nc legacy/nc v0.14+)? In order to determine your bookmarks app version: Are you able to create folders in the web UI?
@Tank-Missile commented on GitHub (Nov 26, 2018):
I'm using 0.14+ and I can create folders in the bookmarks app web ui.
@marcelklehr commented on GitHub (Nov 27, 2018):
In case you were using the server folder feature this issue should be fixed in the next release.
@Tank-Missile commented on GitHub (Nov 30, 2018):
I tried 3.1.14, but now I'm getting a different error: Folder #-1[undefined] contains an nonexistent bookmark 6
@marcelklehr commented on GitHub (Nov 30, 2018):
What does the debug log say?
@Tank-Missile commented on GitHub (Nov 30, 2018):
It's the same as before.
@marcelklehr commented on GitHub (Nov 30, 2018):
mmh. For some reason, the server returns no bookmarks at all, yet, tells floccus that bookmark with id 6 is in the root folder. Are there any bookmarks visible in the bookmarks web UI?
@Tank-Missile commented on GitHub (Nov 30, 2018):
There are no bookmarks in the web ui. I deleted all bookmarks prior to syncing.
@muppeth commented on GitHub (Nov 30, 2018):
@Tank-Missile hi I'm an admin of disroot, cloud you perhaps contact us via support_at_disroot.org so we could examine whats going on on our end and possibly supply more details (like database query results etc) to @marcelklehr
@muppeth commented on GitHub (Nov 30, 2018):
Seems like we just reproduced the error. We'll supply more information over the weekend.
@marcelklehr commented on GitHub (Dec 1, 2018):
I think I've identified the bug. In multi-user environments the bookmarks app currently returns other user's bookmark IDs (but no actual data).
@marcelklehr commented on GitHub (Dec 9, 2018):
This should be fixed with bookmarks v0.14.3 -- please confirm :)
@Tank-Missile commented on GitHub (Dec 11, 2018):
I just gave 3.1.15 a go and my bookmarks successfully synced to my disroot account! Thank you @marcelklehr and @muppeth. I assume the bookmarks app version was updated on the website. I also tested bookmark ordering by deleting my bookmarks locally and syncing. It preserved the order perfectly along with the ordering in folders! I think it's safe to say this extension has superseded xmarks!
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.