[GH-ISSUE #201] Cannot read property 'id' of undefined #192

Closed
opened 2026-02-25 22:36:25 +03:00 by kerem · 16 comments
Owner

Originally created by @Tank-Missile on GitHub (Nov 26, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/201

Software versions

  • Browser: Chromium 70.0.3538.77
  • Nextcloud: 14
  • Nextcloud Bookmarks app: Not sure?
  • Floccus: 3.1.11

I'm using a provider (https://cloud.disroot.org), so I'm not sure how to check the bookmarks app version. I'm not even sure if the nextcloud version (14) is completely accurate either.

Steps to reproduce

Just attempting a manual sync will cause the error.

Expected outcome

My bookmarks sync with my account and show up in the bookmarks app.

Actual outcome

Cannot read property 'id' of undefined.

Originally created by @Tank-Missile on GitHub (Nov 26, 2018). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/201 ### Software versions * Browser: Chromium 70.0.3538.77 * Nextcloud: 14 * Nextcloud Bookmarks app: Not sure? * Floccus: 3.1.11 I'm using a provider (https://cloud.disroot.org), so I'm not sure how to check the bookmarks app version. I'm not even sure if the nextcloud version (14) is completely accurate either. ### Steps to reproduce Just attempting a manual sync will cause the error. ### Expected outcome My bookmarks sync with my account and show up in the bookmarks app. ### Actual outcome Cannot read property 'id' of undefined.
kerem closed this issue 2026-02-25 22:36:25 +03:00
Author
Owner

@marcelklehr commented on GitHub (Nov 26, 2018):

Can you provide the debug log?

<!-- gh-comment-id:441719749 --> @marcelklehr commented on GitHub (Nov 26, 2018): Can you provide the debug log?
Author
Owner

@Tank-Missile commented on GitHub (Nov 26, 2018):

Starting sync process for account
Overriding title of built-in node 1 Bookmarks bar => Bookmarks Bar
Fetching bookmarks
Received bookmarks from server []

This is all the log provides.

<!-- gh-comment-id:441777880 --> @Tank-Missile commented on GitHub (Nov 26, 2018): > Starting sync process for account > Overriding title of built-in node 1 Bookmarks bar => Bookmarks Bar > Fetching bookmarks > Received bookmarks from server [] This is all the log provides.
Author
Owner

@marcelklehr commented on GitHub (Nov 26, 2018):

Which sync method do you use (webdav/nc legacy/nc v0.14+)? In order to determine your bookmarks app version: Are you able to create folders in the web UI?

<!-- gh-comment-id:441829876 --> @marcelklehr commented on GitHub (Nov 26, 2018): Which sync method do you use (webdav/nc legacy/nc v0.14+)? In order to determine your bookmarks app version: Are you able to create folders in the web UI?
Author
Owner

@Tank-Missile commented on GitHub (Nov 26, 2018):

I'm using 0.14+ and I can create folders in the bookmarks app web ui.

<!-- gh-comment-id:441832979 --> @Tank-Missile commented on GitHub (Nov 26, 2018): I'm using 0.14+ and I can create folders in the bookmarks app web ui.
Author
Owner

@marcelklehr commented on GitHub (Nov 27, 2018):

In case you were using the server folder feature this issue should be fixed in the next release.

<!-- gh-comment-id:442240362 --> @marcelklehr commented on GitHub (Nov 27, 2018): In case you were using the server folder feature this issue should be fixed in the next release.
Author
Owner

@Tank-Missile commented on GitHub (Nov 30, 2018):

I tried 3.1.14, but now I'm getting a different error: Folder #-1[undefined] contains an nonexistent bookmark 6

<!-- gh-comment-id:443285026 --> @Tank-Missile commented on GitHub (Nov 30, 2018): I tried 3.1.14, but now I'm getting a different error: Folder #-1[undefined] contains an nonexistent bookmark 6
Author
Owner

@marcelklehr commented on GitHub (Nov 30, 2018):

What does the debug log say?

<!-- gh-comment-id:443293424 --> @marcelklehr commented on GitHub (Nov 30, 2018): What does the debug log say?
Author
Owner

@Tank-Missile commented on GitHub (Nov 30, 2018):

Starting sync process for account
Overriding title of built-in node 1 Bookmarks bar => Bookmarks Bar
Fetching bookmarks
Received bookmarks from server []

It's the same as before.

<!-- gh-comment-id:443305551 --> @Tank-Missile commented on GitHub (Nov 30, 2018): > Starting sync process for account > Overriding title of built-in node 1 Bookmarks bar => Bookmarks Bar > Fetching bookmarks > Received bookmarks from server [] It's the same as before.
Author
Owner

@marcelklehr commented on GitHub (Nov 30, 2018):

mmh. For some reason, the server returns no bookmarks at all, yet, tells floccus that bookmark with id 6 is in the root folder. Are there any bookmarks visible in the bookmarks web UI?

<!-- gh-comment-id:443306691 --> @marcelklehr commented on GitHub (Nov 30, 2018): mmh. For some reason, the server returns no bookmarks at all, yet, tells floccus that bookmark with id 6 is in the root folder. Are there any bookmarks visible in the bookmarks web UI?
Author
Owner

@Tank-Missile commented on GitHub (Nov 30, 2018):

There are no bookmarks in the web ui. I deleted all bookmarks prior to syncing.

<!-- gh-comment-id:443308805 --> @Tank-Missile commented on GitHub (Nov 30, 2018): There are no bookmarks in the web ui. I deleted all bookmarks prior to syncing.
Author
Owner

@muppeth commented on GitHub (Nov 30, 2018):

@Tank-Missile hi I'm an admin of disroot, cloud you perhaps contact us via support_at_disroot.org so we could examine whats going on on our end and possibly supply more details (like database query results etc) to @marcelklehr

<!-- gh-comment-id:443348712 --> @muppeth commented on GitHub (Nov 30, 2018): @Tank-Missile hi I'm an admin of disroot, cloud you perhaps contact us via support_at_disroot.org so we could examine whats going on on our end and possibly supply more details (like database query results etc) to @marcelklehr
Author
Owner

@muppeth commented on GitHub (Nov 30, 2018):

Seems like we just reproduced the error. We'll supply more information over the weekend.

<!-- gh-comment-id:443350187 --> @muppeth commented on GitHub (Nov 30, 2018): Seems like we just reproduced the error. We'll supply more information over the weekend.
Author
Owner

@marcelklehr commented on GitHub (Dec 1, 2018):

I think I've identified the bug. In multi-user environments the bookmarks app currently returns other user's bookmark IDs (but no actual data).

<!-- gh-comment-id:443427478 --> @marcelklehr commented on GitHub (Dec 1, 2018): I think I've identified the bug. In multi-user environments the bookmarks app currently returns other user's bookmark IDs (but no actual data).
Author
Owner

@marcelklehr commented on GitHub (Dec 9, 2018):

This should be fixed with bookmarks v0.14.3 -- please confirm :)

<!-- gh-comment-id:445500900 --> @marcelklehr commented on GitHub (Dec 9, 2018): This should be fixed with bookmarks v0.14.3 -- please confirm :)
Author
Owner

@Tank-Missile commented on GitHub (Dec 11, 2018):

I just gave 3.1.15 a go and my bookmarks successfully synced to my disroot account! Thank you @marcelklehr and @muppeth. I assume the bookmarks app version was updated on the website. I also tested bookmark ordering by deleting my bookmarks locally and syncing. It preserved the order perfectly along with the ordering in folders! I think it's safe to say this extension has superseded xmarks!

<!-- gh-comment-id:446405456 --> @Tank-Missile commented on GitHub (Dec 11, 2018): I just gave 3.1.15 a go and my bookmarks successfully synced to my disroot account! Thank you @marcelklehr and @muppeth. I assume the bookmarks app version was updated on the website. I also tested bookmark ordering by deleting my bookmarks locally and syncing. It preserved the order perfectly along with the ordering in folders! I think it's safe to say this extension has superseded xmarks!
Author
Owner

@github-actions[bot] commented on GitHub (Mar 21, 2023):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:1477570788 --> @github-actions[bot] commented on GitHub (Mar 21, 2023): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/floccus#192
No description provided.