[PR #1169] [CLOSED] L.175 : added Math.ceil #1823

New issue

Closed

opened 2026-02-25 23:30:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:30:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1169
Author: @pinpontitit
Created: 5/17/2022
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (4)

c11cb68 L.175 : added Math.ceil to only allow integers and respect the failsafe rule : if more than 50%
a146d30 Merge branch 'floccusaddon:develop' into develop
931ef46 Update messages.json
0f844e6 Returned to the line the sync button that was going through screen broder in browser. In french sync is synchronisation, and there's no short word for it, so it's quite long.

📊 Changes

3 files changed (+8 additions, -2 deletions)

View changed files

📝 _locales/en/messages.json (+1 -1)
📝 src/lib/strategies/Default.ts (+1 -1)
📝 src/ui/components/AccountCard.vue (+6 -0)

📄 Description

Added Math.ceil to the line 175. To avoid decimal numbers and only allow integers.
"Ceil" because if its 50.00145 %, it'd be preferable to show 51%, as the failsafe rule in settings states that it will only trigger when "more" than 50% is removed.

Fixes #1167

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1169 **Author:** [@pinpontitit](https://github.com/pinpontitit) **Created:** 5/17/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (4) - [`c11cb68`](https://github.com/floccusaddon/floccus/commit/c11cb68967b66ccb5e077ee8223b9cbd6a9ba94a) L.175 : added Math.ceil to only allow integers and respect the failsafe rule : if more than 50% - [`a146d30`](https://github.com/floccusaddon/floccus/commit/a146d30b1fc4ce37d3e8931938911b98da43beff) Merge branch 'floccusaddon:develop' into develop - [`931ef46`](https://github.com/floccusaddon/floccus/commit/931ef464d7389bf8db47d123c9609c9532dbd11f) Update messages.json - [`0f844e6`](https://github.com/floccusaddon/floccus/commit/0f844e60756a0c373d15fe6be173cb91dba4d2f7) Returned to the line the sync button that was going through screen broder in browser. In french sync is synchronisation, and there's no short word for it, so it's quite long. ### 📊 Changes **3 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `_locales/en/messages.json` (+1 -1) 📝 `src/lib/strategies/Default.ts` (+1 -1) 📝 `src/ui/components/AccountCard.vue` (+6 -0) </details> ### 📄 Description Added Math.ceil to the line 175. To avoid decimal numbers and only allow integers. "Ceil" because if its 50.00145 %, it'd be preferable to show 51%, as the failsafe rule in settings states that it will only trigger when "more" than 50% is removed. Fixes #1167 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:30:56 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1823

No description provided.

Rows
Columns