mirror of
https://github.com/hayleox/flags.git
synced 2026-04-25 06:35:47 +03:00
[GH-ISSUE #5] Clean up NL flags folder #6
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flags#6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @RudeySH on GitHub (Nov 14, 2017).
Original GitHub issue: https://github.com/hayleox/flags/issues/5
The Netherlands has 12 provinces. Right now the
nlfolder contains 16 flags.bq1.svg,bq2.svgandbq3.svgcan be removed, as they can already be found in thebqfolder, which is a better location.aw.svg,cw.svgandsx.svgare not flags from provinces of the Netherlands. I am not sure where these belong, but not here.This leaves us with 10 flags, these are correct. South Holland (zh) and Zeeland (ze) are missing. These 2 should be added.
@hayleox commented on GitHub (Nov 14, 2017):
The goal here is to fully support the ISO 3166-2 standard, which sometimes has redundant codes. I don't want to force anyone using this repository to use one format or the other, so I'll have duplicate flags if the standard calls for it. All those flags are named according to the ISO-3166-2:NL; more info here: https://en.wikipedia.org/wiki/ISO_3166-2:NL
Oops, just noticed the missing flags bit of your message. I'll go ahead and add those.
@RudeySH commented on GitHub (Nov 14, 2017):
I see. Still, ZH and ZE are missing. Could you add those?
@hayleox commented on GitHub (Nov 14, 2017):
Yep, just added them!
@RudeySH commented on GitHub (Nov 14, 2017):
Thanks for the quick responses!