mirror of
https://github.com/hayleox/flags.git
synced 2026-04-25 06:35:47 +03:00
[GH-ISSUE #6] Optimize SVGs for web #4
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flags#4
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @RudeySH on GitHub (Nov 14, 2017).
Original GitHub issue: https://github.com/hayleox/flags/issues/6
SVG images should be optimized for web. I'm not use if this is already done, optimization isn't mentioned in the readme.
I don't really know anything about SVG optimization but I do know SVGO is a popular tool for doing this.
Thoughts?
@hayleox commented on GitHub (Nov 14, 2017):
No this isn't done currently; never got around to it. The SVGs are currently just directly how they appeared in Wikipedia (and Wikipedia editors generally oppose hosting optimized SVGs). I'll look into SVGO when I've got time today.
@RudeySH commented on GitHub (Nov 16, 2017):
I could make a pull request from my fork on which I just made a commit that optimizes SVGs, however it also optimizes the flags added in #8 and #9 which have to be accepted first.
@hayleox commented on GitHub (Nov 16, 2017):
Sure, if you don't mind making that PR, I'd be incredibly appreciative.
@RudeySH commented on GitHub (Nov 16, 2017):
Ah, I just noticed my fork still includes some flags that this repository does not have, those also have to be merged first. See #11.
@hayleox commented on GitHub (Nov 16, 2017):
Hey, before you bother with the SVG optimization -- I think what might be preferable is for me to setup a build script for the public version of the repository that optimizes the SVGs and also generates the PNGs. I'm figuring out my options for hosting this somewhere better than GH Pages and probably on a new domain name. (#12)