[GH-ISSUE #486] viewBox instead of absolute width/height? #297

New issue

Closed

opened 2026-03-03 14:37:19 +03:00 by kerem · 1 comment

kerem commented

2026-03-03 14:37:19 +03:00

Owner

Originally created by @s-h-a-d-o-w on GitHub (Sep 14, 2018).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/486

Is there a specific reason for specifying a fixed width/height?

It seems to me that everyone will resize the flags to whatever they need anyway. With the recommended CSS workflow, that's simple enough. But if you want to use the SVGs directly (personally, I'm using https://github.com/airbnb/babel-plugin-inline-react-svg ) it just won't work. At least not out of the box.

I tried it out with your demo page - changed the greek flag to only have a viewBox of 0 0 640 480 and everything still renders properly.

Personally, I only need a few flags anyway and am fine with manually editing them but it seems to me that it might be beneficial for the future in general if this was changed.

Originally created by @s-h-a-d-o-w on GitHub (Sep 14, 2018). Original GitHub issue: https://github.com/lipis/flag-icons/issues/486 Is there a specific reason for specifying a fixed width/height? It seems to me that everyone will resize the flags to whatever they need anyway. With the recommended CSS workflow, that's simple enough. But if you want to use the SVGs directly (personally, I'm using https://github.com/airbnb/babel-plugin-inline-react-svg ) it just won't work. At least not out of the box. I tried it out with your demo page - changed the greek flag to only have a viewBox of 0 0 640 480 and everything still renders properly. Personally, I only need a few flags anyway and am fine with manually editing them but it seems to me that it might be beneficial for the future in general if this was changed.